feat(global): added RTL support #5778

mcoker · 2023-07-24T22:22:18Z

fixes #5791 and also implements logical properties across the library.

The changes:

Search and replace
- padding-[top, right, bottom, left]
- margin-[top, right, bottom, left]
- text-align: [left/right]]
- [top/right/bottom/left]
- border-[...]-[top/right/bottom/left]
Manual conversion of shorthand to longhand values (eg, margin: 1 2 3 to margin-block-start: 1; margin-inline-end: 2; margin-block-end: 3; margin-inline-start: 2;)
Re-ordered a bunch of property declarations manually. I think stylelint fixed a few, but I moved most by hand
Used shorthand property declaration for spacing utility x/y classes.

Some build related changes:

Adds backstop screenshot visual regression tool^[1]
Adds use-logical-spec stylelint rule - currently set to always. This is a good baseline that there are no non-logical properties defined anywhere. We may need to modify that if we add directional properties back when RTL testing.

[1] - The TL;DR of backstop:

Tests against the prod build (yarn build && yarn serve - listens on localhost:5000)
Tests every example and demo - grabbed the URLs from our existing screenshot tool's method of grabbing example/demo URLs
Tests on 3 viewports (mobile, tablet, desktop)
It does not have any screenshots stored currently - adding screenshots in this PR to use as baseline to test against crashed the "files changed" tab since it adds a ton of images. Maybe that could be added at a separate time.
Total testing time for all URLs viewports is around 20-30 minutes, I believe
All of ^ is configurable. You can test specific URLs/components, viewports, test against the dev server on :8001, etc

Questions for @nicolethoen @wise-king-sullyman @tlabaj

We have issues of taking a screenshot before the page has fully rendered. Is there some sort of event triggered on the page when everything has loaded that we could use to add a class to the page (eg, .window-load)? If so we could configure the screenshot tool to wait until that class is present before grabbing a screenshot.
I wonder if we could include the styles that disable animations/transitions (and here they are in the docs framework package) as styles included from the docs framework if some thing is set - a query string parameter (`?disable-animations1), a cookie, a media query (puppeteer can set media features), etc...

patternfly-build · 2023-07-24T22:29:21Z

Preview: https://patternfly-pr-5778.surge.sh

A11y report: https://patternfly-pr-5778-a11y.surge.sh

srambach · 2023-07-25T21:10:31Z

Quick half-first-pass of things to address:

jumplinks border
caret rotation/direction
on the workspace the HTML code doesn't show up
progress stepper spacing and vertical line
slider - ball is off and ticks are off
switch - ball is misplaced
breadcrumbs - reverse the caret
dual list selector - carets, sorting icons, search input
form control spacing with icons
text input group search icon
tree view general wonkiness
Utility classes - do we rename/add logical properties?
alert icon spacing

srambach · 2023-08-14T20:50:41Z

backstop_data/engine_scripts/cookies.json

@@ -0,0 +1,14 @@
+[
+  {
+    "domain": ".www.yourdomain.com",


Is this file supposed to be customized for PatternFly?

Not this file, they provide a lot of example/templates for different configs/scripts you might want to use when testing. This would set a cookie with some value you might need for chromium to access a test URL

srambach

I'm ok with getting this merged since the diffs look good and we'll follow quickly with a visit to each component for checking RTL. I'd love to see a 👍 from @nicolethoen or @dgutride on the backstop stuff.

tlabaj · 2023-08-15T16:51:57Z

Questions for @nicolethoen @wise-king-sullyman @tlabaj

We have issues of taking a screenshot before the page has fully rendered. Is there some sort of event triggered on the page when everything has loaded that we could use to add a class to the page (eg, .window-load)? If so we could configure the screenshot tool to wait until that class is present before grabbing a screenshot.

@mcoker I believe this is what you are looking for
https://developer.mozilla.org/en-US/docs/Web/API/Window/load_event

nicolethoen

No objections from me!
I opened followup issues to track tech-debt
#5848
patternfly/patternfly-org#3703

patternfly-build · 2023-08-22T20:33:45Z

🎉 This PR is included in version 5.1.0-prerelease.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

* chore(select): fixed text in HTML example to show multiple checks can be selected (#5663) * chore: Update release.yml to node 18 [ci skip] * chore: add superclean npm script (#5798) * chore(options-menu): updated markup to match react component (#5809) * chore(deps): update dependency @patternfly/documentation-framework to v5.1.3 (#5720) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): bump semver from 5.7.1 to 5.7.2 (#5756) Bumps [semver](https://github.com/npm/node-semver) from 5.7.1 to 5.7.2. - [Release notes](https://github.com/npm/node-semver/releases) - [Changelog](https://github.com/npm/node-semver/blob/v5.7.2/CHANGELOG.md) - [Commits](npm/node-semver@v5.7.1...v5.7.2) --- updated-dependencies: - dependency-name: semver dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix: updated use of flex start/end to be more compatible (#5807) * fix(chip): add margin for badge when used in text element (#5844) * feat(global): added RTL support (#5778) * fix: added tree view icon (#5845) * fix: added tree view icon * chore: put treeviewicon in alphabetical order * chore: rtl fixes, screenshots (#5854) * chore: rtl fixes, screenshots * chore: checkin screenshots * chore(deps): update dependency @patternfly/documentation-framework to v5.1.7 (#5852) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore: enable RTL switcher on full page examples (#5859) * docs: update location of and references to docs to consolidate and organize information. (#5773) * fix: added base, wizard, pagination RTL styles (#5860) * chore(Accordion,ExpandableSection): added more RTL styling (#5861) * fix(RTL): refactor mixins, add slider rtl styles (#5867) * fix(nav): added optional text wrapper for nav text (#5868) * chore(deps): update dependency @patternfly/documentation-framework to v5.1.9 (#5863) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(Toolbar): updated toolbar pagination structure (#5862) * fix(breadcrumb): added rtl support (#5870) * chore(card): updated horiz demo image (#5875) * chore(Alert,NotificationDrawer): added additional rtl styling (#5866) * chore(deps): update dependency @patternfly/documentation-framework to v5.1.10 (#5880) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(Nav, Menu): apply RTL fixes (#5873) * fix(clipboard-copy): added rtl styles (#5876) * fix(page): added rtl styles (#5878) * fix(calendar-month): rtl support (#5869) * chore(Card,Tile): apply RTL fixes (#5881) * fix: added tabs and jump links rtl styles (#5877) * chore(deps): update dependency @patternfly/documentation-framework to v5.1.11 (#5885) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(DataList): added additional rtl styling (#5871) * chore(DataList): added additional rtl styling * Add comment to update notif badge in breaking change * fix(popover, tooltip): added rtl styles (#5882) * fix(tree-view): added rtl styles (#5883) * chore(Table): added additional RTL styling (#5887) * chore(Drawer): transforms and shadows on RTL drawer (#5888) * fix(forms): updated rtl styles (#5889) * fix(skeleton): added rtl styles (#5891) * chore(deps): update dependency @patternfly/documentation-framework to v5.1.12 (#5894) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(slider): added root decl for var to create react token (#5895) * chore(ModalBox): center modal for workspace in RTL (#5893) * fix(rtl): fixes truncate rtl (#5874) * fix(ModalBox): fix centering on mobile (#5905) * chore: added backstop as dev dependency, update config (#5904) * chore(popover): center examples (#5906) * fix(nav): updated example css (#5903) * chore(deps): update dependency @patternfly/documentation-framework to v5.1.14 (#5909) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix: remove workspace RTL classes (#5912) * chore: update screenshots (#5915) * fix: Update upload-preview.js to use new workspace url * chore(deps): update dependency @patternfly/documentation-framework to v5.1.15 (#5916) * chore(deps): update dependency @patternfly/react-table to v5.0.1 (#5914) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @patternfly/react-code-editor to v5.0.1 (#5910) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @patternfly/react-core to v5.0.1 (#5913) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore: mirror fa-sort icon (#5920) * fix: mirror bg image position in rtl (#5922) * fix(progress): updated indicator direction (#5923) * chore: update readme to reference new workspace url * chore(deps): update dependency @patternfly/documentation-framework to v5.2.0 (#5925) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(code-editor): make code box and header LTR (#5928) * fix(code-editor): make code box and header LTR * chore: refactor to use dir instead of css for ltr on code block * fix(banner): fixed invalid dark theme color declaration (#5933) * chore(deps): update dependency @patternfly/documentation-framework to v5.2.2 (#5934) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @patternfly/documentation-framework to v5.2.3 (#5940) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(clipboard-copy): add code example with rtl support (#5941) * fix(card): removed border from clickable/selectable selected (#5935) * feat(Button): extended inline styling (#5696) * fix(menu): updated drilldown breadcrumb menu icons to work in RTL (#5924) * fix(toolbar): fix expand all icon in RTL (#5937) * chore(toolbar): mirror expand all icon in rtl * chore: update * chore: use icon shouldMirrorRTL param * fix(popover/tooltip): revert arrow logical prop positioning (#5952) * fix(popover/tooltip): revert arrow logical prop positioning * chore: add missing local css import * chore(screenshots): updated full page screenshots (#5960) * chore(deps): update dependency @patternfly/react-core to v5.1.1 (#5975) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps-dev): bump postcss from 8.4.27 to 8.4.31 (#5971) * chore(Toolbar): increase workspace container height (#5962) * chore(screenshots): update visual regression screenshots (#5959) * chore(deps): update dependency @patternfly/documentation-framework to v5.2.17 (#5961) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @patternfly/react-table to v5.1.1 (#5977) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @patternfly/react-code-editor to v5.1.1 (#5974) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(check-radio): added aria-describedby to check/radio (#5969) * chore(deps): update dependency @patternfly/documentation-framework to v5.2.18 (#5982) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(brand/card): update examples to display logo in dark theme (#5681) * fix(input): standardized check and radio alignment (#5947) * chore(deps): update dependency @patternfly/documentation-framework to v5.2.19 (#5985) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @patternfly/documentation-framework to v5.2.20 (#5994) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): bump @babel/traverse from 7.22.15 to 7.23.2 (#6001) Bumps [@babel/traverse](https://github.com/babel/babel/tree/HEAD/packages/babel-traverse) from 7.22.15 to 7.23.2. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.23.2/packages/babel-traverse) --- updated-dependencies: - dependency-name: "@babel/traverse" dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix(Switch): updated focus style to focus-visible (#5995) * chore(menu-toggle): updated demos to use menu-toggle (#5782) * chore(deps): update dependency @patternfly/documentation-framework to v5.2.24 (#6014) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * feat(Accordion): added left-aligned toggle variant (#5987) * chore(deps): update dependency @patternfly/documentation-framework to v5.2.26 (#6020) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore: V6 merge main.10.30 (#6023) * chore(deps): update dependency @patternfly/documentation-framework to v5.3.0 (#6027) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(main): reverts to pre-v6 merge (#6038) * chore(deps): update dependency @patternfly/documentation-framework to v5.3.1 (#6040) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(globals): update invalid selector in global css (#6044) * feat(breaker): bump this version to 6.0 (#5800) BREAKING CHANGE: 6.0.0-alpha.0 * fix: white space change to kick off dry run * fix: use prerelease tag format with dry run * fix: turn off dryrun * feat(tokens): add initial global tokens (#5843) * feat(Button): adds tokens and applies to buttons (#5908) * feat(table): apply tokens from hackathon (#5965) * feat(menu-toggle): add in work from hackathon (#5931) * feat(nav): adds tokens to page and nav (#5942) * chore(tokens): update tokens from figma (#5970) * feat(page): page and masthead updates from hackathon (#5968) * chore(v6): merge main into v6 (#5981) * fix(tokens): add dark theme blend mode token (#5992) * feat(notificationBadge): refactor with tokens (#5991) * chore(masthead ): applied tokens (#6004) * feat(alert): apply tokens (#6002) * feat(alert): apply tokens * feat(alert): remove unused background color * feat(page): apply tokens (#6021) * feat(page): apply tokens * feat(page): undo menu__list change * feat(page): tweak spacing * fix(table): fix clickable overlay (#6025) * fix(box-shadow): typo in box shadow token names (#6039) * fix(badge): adds tokens, dropdown toggle icon (#6037) * feat(hint): apply tokens (#6030) * feat(hint): apply tokens * feat(hint): fix typo * feat(hint): update spacing * feat(hint): update border radius * feat(hint): fix heading font --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Ashley Ray <[email protected]> Co-authored-by: Nicole Thoen <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Erin Donehoo <[email protected]> Co-authored-by: Eric Olkowski <[email protected]> Co-authored-by: Sarah Rambacher <[email protected]> Co-authored-by: Matt Nolting <[email protected]> Co-authored-by: Jenny <[email protected]>

* chore(select): fixed text in HTML example to show multiple checks can be selected (patternfly#5663) * chore: Update release.yml to node 18 [ci skip] * chore: add superclean npm script (patternfly#5798) * chore(options-menu): updated markup to match react component (patternfly#5809) * chore(deps): update dependency @patternfly/documentation-framework to v5.1.3 (patternfly#5720) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): bump semver from 5.7.1 to 5.7.2 (patternfly#5756) Bumps [semver](https://github.com/npm/node-semver) from 5.7.1 to 5.7.2. - [Release notes](https://github.com/npm/node-semver/releases) - [Changelog](https://github.com/npm/node-semver/blob/v5.7.2/CHANGELOG.md) - [Commits](npm/node-semver@v5.7.1...v5.7.2) --- updated-dependencies: - dependency-name: semver dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix: updated use of flex start/end to be more compatible (patternfly#5807) * fix(chip): add margin for badge when used in text element (patternfly#5844) * feat(global): added RTL support (patternfly#5778) * fix: added tree view icon (patternfly#5845) * fix: added tree view icon * chore: put treeviewicon in alphabetical order * chore: rtl fixes, screenshots (patternfly#5854) * chore: rtl fixes, screenshots * chore: checkin screenshots * chore(deps): update dependency @patternfly/documentation-framework to v5.1.7 (patternfly#5852) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore: enable RTL switcher on full page examples (patternfly#5859) * docs: update location of and references to docs to consolidate and organize information. (patternfly#5773) * fix: added base, wizard, pagination RTL styles (patternfly#5860) * chore(Accordion,ExpandableSection): added more RTL styling (patternfly#5861) * fix(RTL): refactor mixins, add slider rtl styles (patternfly#5867) * fix(nav): added optional text wrapper for nav text (patternfly#5868) * chore(deps): update dependency @patternfly/documentation-framework to v5.1.9 (patternfly#5863) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(Toolbar): updated toolbar pagination structure (patternfly#5862) * fix(breadcrumb): added rtl support (patternfly#5870) * chore(card): updated horiz demo image (patternfly#5875) * chore(Alert,NotificationDrawer): added additional rtl styling (patternfly#5866) * chore(deps): update dependency @patternfly/documentation-framework to v5.1.10 (patternfly#5880) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(Nav, Menu): apply RTL fixes (patternfly#5873) * fix(clipboard-copy): added rtl styles (patternfly#5876) * fix(page): added rtl styles (patternfly#5878) * fix(calendar-month): rtl support (patternfly#5869) * chore(Card,Tile): apply RTL fixes (patternfly#5881) * fix: added tabs and jump links rtl styles (patternfly#5877) * chore(deps): update dependency @patternfly/documentation-framework to v5.1.11 (patternfly#5885) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(DataList): added additional rtl styling (patternfly#5871) * chore(DataList): added additional rtl styling * Add comment to update notif badge in breaking change * fix(popover, tooltip): added rtl styles (patternfly#5882) * fix(tree-view): added rtl styles (patternfly#5883) * chore(Table): added additional RTL styling (patternfly#5887) * chore(Drawer): transforms and shadows on RTL drawer (patternfly#5888) * fix(forms): updated rtl styles (patternfly#5889) * fix(skeleton): added rtl styles (patternfly#5891) * chore(deps): update dependency @patternfly/documentation-framework to v5.1.12 (patternfly#5894) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(slider): added root decl for var to create react token (patternfly#5895) * chore(ModalBox): center modal for workspace in RTL (patternfly#5893) * fix(rtl): fixes truncate rtl (patternfly#5874) * fix(ModalBox): fix centering on mobile (patternfly#5905) * chore: added backstop as dev dependency, update config (patternfly#5904) * chore(popover): center examples (patternfly#5906) * fix(nav): updated example css (patternfly#5903) * chore(deps): update dependency @patternfly/documentation-framework to v5.1.14 (patternfly#5909) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix: remove workspace RTL classes (patternfly#5912) * chore: update screenshots (patternfly#5915) * fix: Update upload-preview.js to use new workspace url * chore(deps): update dependency @patternfly/documentation-framework to v5.1.15 (patternfly#5916) * chore(deps): update dependency @patternfly/react-table to v5.0.1 (patternfly#5914) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @patternfly/react-code-editor to v5.0.1 (patternfly#5910) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @patternfly/react-core to v5.0.1 (patternfly#5913) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore: mirror fa-sort icon (patternfly#5920) * fix: mirror bg image position in rtl (patternfly#5922) * fix(progress): updated indicator direction (patternfly#5923) * chore: update readme to reference new workspace url * chore(deps): update dependency @patternfly/documentation-framework to v5.2.0 (patternfly#5925) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(code-editor): make code box and header LTR (patternfly#5928) * fix(code-editor): make code box and header LTR * chore: refactor to use dir instead of css for ltr on code block * fix(banner): fixed invalid dark theme color declaration (patternfly#5933) * chore(deps): update dependency @patternfly/documentation-framework to v5.2.2 (patternfly#5934) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @patternfly/documentation-framework to v5.2.3 (patternfly#5940) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(clipboard-copy): add code example with rtl support (patternfly#5941) * fix(card): removed border from clickable/selectable selected (patternfly#5935) * feat(Button): extended inline styling (patternfly#5696) * fix(menu): updated drilldown breadcrumb menu icons to work in RTL (patternfly#5924) * fix(toolbar): fix expand all icon in RTL (patternfly#5937) * chore(toolbar): mirror expand all icon in rtl * chore: update * chore: use icon shouldMirrorRTL param * fix(popover/tooltip): revert arrow logical prop positioning (patternfly#5952) * fix(popover/tooltip): revert arrow logical prop positioning * chore: add missing local css import * chore(screenshots): updated full page screenshots (patternfly#5960) * chore(deps): update dependency @patternfly/react-core to v5.1.1 (patternfly#5975) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps-dev): bump postcss from 8.4.27 to 8.4.31 (patternfly#5971) * chore(Toolbar): increase workspace container height (patternfly#5962) * chore(screenshots): update visual regression screenshots (patternfly#5959) * chore(deps): update dependency @patternfly/documentation-framework to v5.2.17 (patternfly#5961) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @patternfly/react-table to v5.1.1 (patternfly#5977) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @patternfly/react-code-editor to v5.1.1 (patternfly#5974) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(check-radio): added aria-describedby to check/radio (patternfly#5969) * chore(deps): update dependency @patternfly/documentation-framework to v5.2.18 (patternfly#5982) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(brand/card): update examples to display logo in dark theme (patternfly#5681) * fix(input): standardized check and radio alignment (patternfly#5947) * chore(deps): update dependency @patternfly/documentation-framework to v5.2.19 (patternfly#5985) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @patternfly/documentation-framework to v5.2.20 (patternfly#5994) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): bump @babel/traverse from 7.22.15 to 7.23.2 (patternfly#6001) Bumps [@babel/traverse](https://github.com/babel/babel/tree/HEAD/packages/babel-traverse) from 7.22.15 to 7.23.2. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.23.2/packages/babel-traverse) --- updated-dependencies: - dependency-name: "@babel/traverse" dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix(Switch): updated focus style to focus-visible (patternfly#5995) * chore(menu-toggle): updated demos to use menu-toggle (patternfly#5782) * chore(deps): update dependency @patternfly/documentation-framework to v5.2.24 (patternfly#6014) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * feat(Accordion): added left-aligned toggle variant (patternfly#5987) * chore(deps): update dependency @patternfly/documentation-framework to v5.2.26 (patternfly#6020) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore: V6 merge main.10.30 (patternfly#6023) * chore(deps): update dependency @patternfly/documentation-framework to v5.3.0 (patternfly#6027) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(main): reverts to pre-v6 merge (patternfly#6038) * chore(deps): update dependency @patternfly/documentation-framework to v5.3.1 (patternfly#6040) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(globals): update invalid selector in global css (patternfly#6044) * feat(breaker): bump this version to 6.0 (patternfly#5800) BREAKING CHANGE: 6.0.0-alpha.0 * fix: white space change to kick off dry run * fix: use prerelease tag format with dry run * fix: turn off dryrun * feat(tokens): add initial global tokens (patternfly#5843) * feat(Button): adds tokens and applies to buttons (patternfly#5908) * feat(table): apply tokens from hackathon (patternfly#5965) * feat(menu-toggle): add in work from hackathon (patternfly#5931) * feat(nav): adds tokens to page and nav (patternfly#5942) * chore(tokens): update tokens from figma (patternfly#5970) * feat(page): page and masthead updates from hackathon (patternfly#5968) * chore(v6): merge main into v6 (patternfly#5981) * fix(tokens): add dark theme blend mode token (patternfly#5992) * feat(notificationBadge): refactor with tokens (patternfly#5991) * chore(masthead ): applied tokens (patternfly#6004) * feat(alert): apply tokens (patternfly#6002) * feat(alert): apply tokens * feat(alert): remove unused background color * feat(page): apply tokens (patternfly#6021) * feat(page): apply tokens * feat(page): undo menu__list change * feat(page): tweak spacing * fix(table): fix clickable overlay (patternfly#6025) * fix(box-shadow): typo in box shadow token names (patternfly#6039) * fix(badge): adds tokens, dropdown toggle icon (patternfly#6037) * feat(hint): apply tokens (patternfly#6030) * feat(hint): apply tokens * feat(hint): fix typo * feat(hint): update spacing * feat(hint): update border radius * feat(hint): fix heading font --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Ashley Ray <[email protected]> Co-authored-by: Nicole Thoen <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Erin Donehoo <[email protected]> Co-authored-by: Eric Olkowski <[email protected]> Co-authored-by: Sarah Rambacher <[email protected]> Co-authored-by: Matt Nolting <[email protected]> Co-authored-by: Jenny <[email protected]>

mcoker force-pushed the issue-5757 branch 2 times, most recently from 9c58b17 to e2f2a79 Compare August 3, 2023 22:56

mcoker force-pushed the issue-5757 branch 2 times, most recently from 7095d2f to cab1dd8 Compare August 10, 2023 21:40

mcoker added 8 commits August 14, 2023 15:05

feat(global): added RTL support

59539c3

chore: update label padding

15650ef

chore: backstop updates

a32eb86

chore: backstop updates

5ee089b

chore: backstop

0b55c2d

chore: backstop config

bf140a5

chore: remove base screenshots

70146b8

chore: whitespace

a699360

mcoker force-pushed the issue-5757 branch from 55efb06 to a699360 Compare August 14, 2023 20:06

mcoker marked this pull request as ready for review August 14, 2023 20:06

srambach reviewed Aug 14, 2023

View reviewed changes

srambach approved these changes Aug 15, 2023

View reviewed changes

mcoker requested review from mattnolting, nicolethoen and wise-king-sullyman August 15, 2023 15:05

nicolethoen approved these changes Aug 15, 2023

View reviewed changes

mcoker merged commit 56b4f3f into patternfly:main Aug 15, 2023

mcoker mentioned this pull request Aug 17, 2023

feat(deps): introduce stylelint-use-logical-spec stylelint plugin #5556

Closed

patternfly-build added the released on @prerelease label Aug 22, 2023

mattnolting pushed a commit to mattnolting/patternfly that referenced this pull request Dec 12, 2023

feat(global): added RTL support (patternfly#5778)

7a3abde

mcoker deleted the issue-5757 branch January 7, 2025 16:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(global): added RTL support #5778

feat(global): added RTL support #5778

Uh oh!

mcoker commented Jul 24, 2023 •

edited

Loading

Uh oh!

patternfly-build commented Jul 24, 2023 •

edited

Loading

Uh oh!

srambach commented Jul 25, 2023 •

edited

Loading

Uh oh!

srambach Aug 14, 2023

Uh oh!

mcoker Aug 14, 2023

Uh oh!

srambach left a comment

Uh oh!

tlabaj commented Aug 15, 2023

Uh oh!

nicolethoen left a comment

Uh oh!

patternfly-build commented Aug 22, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

feat(global): added RTL support #5778

feat(global): added RTL support #5778

Uh oh!

Conversation

mcoker commented Jul 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

The changes:

Uh oh!

patternfly-build commented Jul 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

srambach commented Jul 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

srambach Aug 14, 2023

Choose a reason for hiding this comment

Uh oh!

mcoker Aug 14, 2023

Choose a reason for hiding this comment

Uh oh!

srambach left a comment

Choose a reason for hiding this comment

Uh oh!

tlabaj commented Aug 15, 2023

Uh oh!

nicolethoen left a comment

Choose a reason for hiding this comment

Uh oh!

patternfly-build commented Aug 22, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

mcoker commented Jul 24, 2023 •

edited

Loading

patternfly-build commented Jul 24, 2023 •

edited

Loading

srambach commented Jul 25, 2023 •

edited

Loading