Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore(DataList): added additional rtl styling #5871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mcoker merged 2 commits into from
Aug 31, 2023
Merged

chore(DataList): added additional rtl styling #5871

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b306fc2
chore(DataList): added additional rtl styling
Aug 29, 2023
890abb1
Add comment to update notif badge in breaking change
Aug 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/patternfly/components/DataList/data-list.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -405,6 +405,8 @@

// toggle icon rotate
.#{$data-list}__toggle-icon {
@include pf-v5-mirror-inline-on-rtl;

height: var(--#{$data-list}__toggle-icon--Height);
pointer-events: none;
transition: var(--#{$data-list}__toggle-icon--Transition);
Expand Down
3 changes: 3 additions & 0 deletions src/patternfly/components/NotificationBadge/notification-badge.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,9 @@
{{#if notification-badge--attribute}}
{{{notification-badge--attribute}}}
{{/if}}>
{{!-- TODO in Breaking Change: Add a wrapper element around the icon to follow
how other components' markup is structured for icons
--}}
Comment on lines +17 to +19
Copy link
Contributor

@mcoker mcoker Aug 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

<i class="
{{~#if notification-badge--IsTask}}
pf-v5-pficon-task
Expand Down