Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore(Nav, Menu): apply RTL fixes #5873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mcoker merged 2 commits into from
Aug 30, 2023
Merged

chore(Nav, Menu): apply RTL fixes #5873

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
93a3bf9
feat(Nav, Menu): apply RTL fixes
srambach Aug 29, 2023
065ca04
feat(Nav, Menu): add calc-inverse
srambach Aug 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions src/patternfly/components/Menu/menu.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,11 @@
// target first list in menu
> .#{$menu}__content > .#{$menu}__list,
> .#{$menu}__list {
transform: translateX(-100%);
@include pf-v5-bidirectional-style(
$prop: transform,
$ltr-val: translateX(-100%),
$rtl-val: translateX(#{pf-v5-calc-inverse(-100%)})
);
}
// stylelint-enable
}
Expand All @@ -299,7 +303,11 @@

// stylelint-disable selector-max-class
&.pf-m-drilled-in {
transform: translateX(-100%);
@include pf-v5-bidirectional-style(
$prop: transform,
$ltr-val: translateX(-100%),
$rtl-val: translateX(#{pf-v5-calc-inverse(-100%)})
);
}
// stylelint-enable
}
Expand Down Expand Up @@ -686,6 +694,8 @@

// Toggle icon
.#{$menu}__item-toggle-icon {
@include pf-v5-mirror-inline-on-rtl;

padding-inline-start: var(--#{$menu}__item-toggle-icon--PaddingLeft);
padding-inline-end: var(--#{$menu}__item-toggle-icon--PaddingRight);
color: var(--#{$menu}__item-toggle-icon, inherit);
Expand Down
24 changes: 22 additions & 2 deletions src/patternfly/components/Nav/nav.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -508,6 +508,8 @@
}

.#{$menu}__item-toggle-icon {
@include pf-v5-mirror-inline-on-rtl;

margin-inline-start: calc(var(--#{$menu}__item-toggle-icon--PaddingLeft) * -1);
}

Expand Down Expand Up @@ -1064,6 +1066,8 @@
display: inline-block;
transition: var(--#{$nav}__toggle-icon--Transition);

@include pf-v5-mirror-inline-on-rtl;

.#{$nav}__item.pf-m-expanded & {
transform: rotate(var(--#{$nav}__item--m-expanded__toggle-icon--Rotate));
}
Expand Down Expand Up @@ -1132,6 +1136,12 @@
opacity: 0;
transition: var(--#{$nav}__scroll-button--Transition);

// Mirror only the contents to avoid flipping the borders
// TODO at breaking change, add an icon wrapper to be mirrored
> * {
@include pf-v5-mirror-inline-on-rtl;
}

&::before {
position: absolute;
inset-block-start: 0;
Expand Down Expand Up @@ -1163,8 +1173,13 @@
--#{$nav}__scroll-button--before--BorderRightWidth: var(--#{$nav}__scroll-button--before--BorderWidth);

margin-inline-end: calc(var(--#{$nav}__scroll-button--Width) * -1);
transform: translateX(-100%);

@include pf-v5-bidirectional-style(
$prop: transform,
$ltr-val: translateX(-100%),
$rtl-val: translateX(#{pf-v5-calc-inverse(-100%)})
);

&::before {
inset-inline-end: 0;
}
Expand All @@ -1174,7 +1189,12 @@
--#{$nav}__scroll-button--before--BorderLeftWidth: var(--#{$nav}__scroll-button--before--BorderWidth);

margin-inline-start: calc(var(--#{$nav}__scroll-button--Width) * -1);
transform: translateX(100%);

@include pf-v5-bidirectional-style(
$prop: transform,
$ltr-val: translateX(100%),
$rtl-val: translateX(#{pf-v5-calc-inverse(100%)})
);

&::before {
inset-inline-start: 0;
Expand Down