Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat(page): page and masthead updates from hackathon #5968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mcoker merged 5 commits into from
Oct 4, 2023
Merged

feat(page): page and masthead updates from hackathon #5968

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
468dcaa
feat(page): page and masthead updates from hackathon
srambach Sep 28, 2023
89bd609
Update src/patternfly/components/Masthead/masthead-logo.hbs
mcoker Oct 4, 2023
9ff0309
Update src/patternfly/components/Page/page-main-list.hbs
mcoker Oct 4, 2023
74b8832
Update src/patternfly/components/Page/page-sidebar-header.hbs
mcoker Oct 4, 2023
1036e49
Update src/patternfly/components/Page/page-sidebar-title.hbs
mcoker Oct 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/patternfly/components/Masthead/masthead-logo.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
<div class="{{pfv}}masthead__logo{{#if masthead-logo--modifier}} {{masthead-logo--modifier}}{{/if}}"
{{#if masthead-logo--attribute}}
{{{masthead-logo--attribute}}}
{{/if}}>
{{> @partial-block}}
</div>
21 changes: 13 additions & 8 deletions src/patternfly/components/Masthead/masthead.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,10 +45,10 @@ $pf-v5-c-masthead--inset-map: build-spacer-map("none", "sm", "md", "lg", "xl", "
.#{$masthead} {
--#{$masthead}--PaddingLeft: var(--#{$masthead}--inset);
--#{$masthead}--PaddingRight: var(--#{$masthead}--inset);
--#{$masthead}--BackgroundColor: var(--#{$pf-global}--BackgroundColor--dark-100);
--#{$masthead}--BackgroundColor: var(--pf-t--global--background--color--secondary--default);

// Insets
--#{$masthead}--inset: var(--#{$pf-global}--spacer--md); // match page insets
--#{$masthead}--inset: var(--pf-t--global--spacer--lg); // match page insets
--#{$masthead}--xl--inset: var(--#{$pf-global}--spacer--lg); // match page insets

// Stack
Expand Down Expand Up @@ -94,7 +94,7 @@ $pf-v5-c-masthead--inset-map: build-spacer-map("none", "sm", "md", "lg", "xl", "
// Main border
--#{$masthead}__main--before--Right: calc(var(--#{$masthead}--inset) * -1);
--#{$masthead}__main--before--Left: calc(var(--#{$masthead}--inset) * -1);
--#{$masthead}__main--before--BorderBottomWidth: var(--#{$pf-global}--BorderWidth--sm);
--#{$masthead}__main--before--BorderBottomWidth: var(--pf-t--global--border--width--divider--default);
--#{$masthead}__main--before--BorderBottomColor: var(--#{$pf-global}--palette--black-600);

// Toggle
Expand All @@ -103,18 +103,18 @@ $pf-v5-c-masthead--inset-map: build-spacer-map("none", "sm", "md", "lg", "xl", "
--#{$masthead}__toggle--c-button--FontSize: var(--#{$pf-global}--FontSize--2xl);

// Light 100
--#{$masthead}--m-light--BackgroundColor: var(--#{$pf-global}--BackgroundColor--100);
--#{$masthead}--m-light--BackgroundColor: var(--pf-t--global--background--color--primary--default);
--#{$masthead}--m-light__main--BorderBottomColor: var(--#{$pf-global}--BorderColor--300);

// Light 200
--#{$masthead}--m-light-200--BackgroundColor: var(--#{$pf-global}--BackgroundColor--200);
--#{$masthead}--m-light-200__main--BorderBottomColor: var(--#{$pf-global}--BorderColor--100);
--#{$masthead}--m-light-200--BackgroundColor: var(--pf-t--global--background--color--secondary--default);
--#{$masthead}--m-light-200__main--BorderBottomColor: var(--pf-t--global--border--color--default);

// Toolbar item
--#{$masthead}--c-toolbar__item--Display: flex;

// Borders
--#{$masthead}--item-border-color--base: var(--#{$pf-global}--palette--black-800);
--#{$masthead}--item-border-color--base: var(--pf-t--global--border--color--default);

// Context selector
--#{$masthead}--c-context-selector--Width: auto;
Expand Down Expand Up @@ -145,7 +145,7 @@ $pf-v5-c-masthead--inset-map: build-spacer-map("none", "sm", "md", "lg", "xl", "
--#{$masthead}--c-toolbar__expandable-content--PaddingRight: var(--#{$masthead}--inset);
--#{$masthead}--c-toolbar__expandable-content--PaddingBottom: var(--#{$pf-global}--spacer--md);
--#{$masthead}--c-toolbar__expandable-content--PaddingLeft: var(--#{$masthead}--inset);
--#{$masthead}--c-toolbar__expandable-content--before--BorderTopWidth: var(--#{$pf-global}--BorderWidth--sm);
--#{$masthead}--c-toolbar__expandable-content--before--BorderTopWidth: var(--pf-t--global--border--width--divider--default);
--#{$masthead}--c-toolbar__expandable-content--before--BorderTopColor: var(--#{$masthead}--item-border-color--base);

// Set layout to stack by default
Expand Down Expand Up @@ -286,6 +286,11 @@ $pf-v5-c-masthead--inset-map: build-spacer-map("none", "sm", "md", "lg", "xl", "
}
}

.#{$masthead}__logo {
display: flex;
gap: var(--pf-t--global--spacer--md);
}

// Content
.#{$masthead}__content {
display: flex;
Expand Down
6 changes: 6 additions & 0 deletions src/patternfly/components/Page/page-main-list.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
<div class="{{pfv}}page__main-list{{#if page-main-list--modifier}} {{page-main-list--modifier}}{{/if}}" tabindex="-1"
{{#if page-main-list--attribute}}
{{{page-main-list--attribute}}}
{{/if}}>
{{> @partial-block}}
</div>
6 changes: 6 additions & 0 deletions src/patternfly/components/Page/page-sidebar-header.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
<div class="{{pfv}}page__sidebar-header{{#if page-sidebar-header--modifier}} {{page-sidebar-header--modifier}}{{/if}}"
{{#if page-sidebar-header--attribute}}
{{{page-sidebar-header--attribute}}}
{{/if}}>
{{> @partial-block}}
</div>
6 changes: 6 additions & 0 deletions src/patternfly/components/Page/page-sidebar-title.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
<h2 class="{{pfv}}page__sidebar-title{{#if page-sidebar-title--modifier}} {{page-sidebar-title--modifier}}{{/if}}"
{{#if page-sidebar-title--attribute}}
{{{page-sidebar-title--attribute}}}
{{/if}}>
{{> @partial-block}}
</h2>
16 changes: 8 additions & 8 deletions src/patternfly/components/Table/table-grid.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,19 +38,19 @@
// ============================================================ //

// Table
--#{$table}--responsive--BorderColor: var(--#{$pf-global}--BorderColor--300);
--#{$table}--responsive--BorderColor: var(--pf-t--global--border--color--default);

// Body
--#{$table}__tbody--responsive--border-width--base: var(--#{$pf-global}--spacer--sm);
--#{$table}__tbody--responsive--border-width--base: var(--pf-t--global--border--width--divider--default);
--#{$table}__tbody--after--border-width--base: var(--#{$pf-global}--BorderWidth--lg);
--#{$table}__tbody--after--BorderLeftWidth: 0;
--#{$table}__tbody--after--BorderColor: var(--#{$pf-global}--active-color--100);
--#{$table}__tbody--after--BorderColor: var(--pf-t--global--border--color--active);

// Row
--#{$table}__tr--responsive--border-width--base: var(--#{$pf-global}--spacer--sm);
--#{$table}__tr--responsive--border-width--base: var(--pf-t--global--border--width--divider--default);
--#{$table}__tr--responsive--last-child--BorderBottomWidth: var(--#{$pf-global}--BorderWidth--sm);
--#{$table}__tr--responsive--GridColumnGap: var(--#{$pf-global}--spacer--md);
--#{$table}__tr--responsive--MarginTop: var(--#{$pf-global}--spacer--sm);
--#{$table}__tr--responsive--MarginTop: var(--pf-t--global--border--width--divider--default);
--#{$table}__tr--responsive--PaddingTop: var(--#{$pf-global}--spacer--md);
--#{$table}__tr--responsive--PaddingRight: var(--#{$pf-global}--spacer--lg);
--#{$table}__tr--responsive--xl--PaddingRight: var(--#{$pf-global}--spacer--md);
Expand All @@ -76,7 +76,7 @@

// selected
--#{$table}__tbody--m-selected--after__tr--BorderLeftWidth: var(--#{$table}__expandable-row--after--border-width--base);
--#{$table}__tbody--m-selected--after__tr--BorderLeftColor: var(--#{$pf-global}--active-color--100);
--#{$table}__tbody--m-selected--after__tr--BorderLeftColor: var(--pf-t--global--border--color--active);

// Cell display
--#{$table}--m-grid--cell--hidden-visible--Display: grid;
Expand Down Expand Up @@ -109,15 +109,15 @@
--#{$table}__expandable-row-content--responsive--PaddingLeft: var(--#{$pf-global}--spacer--lg);
--#{$table}__expandable-row-content--responsive--xl--PaddingRight: var(--#{$pf-global}--spacer--md);
--#{$table}__expandable-row-content--responsive--xl--PaddingLeft: var(--#{$pf-global}--spacer--md);
--#{$table}__expandable-row-content--BackgroundColor: var(--#{$pf-global}--BackgroundColor--100);
--#{$table}__expandable-row-content--BackgroundColor: var(--pf-t--global--background--color--primary--default);

@media screen and (max-width: $pf-v5-global--breakpoint--xl) {
--#{$table}__expandable-row-content--responsive--PaddingRight: var(--#{$table}__expandable-row-content--responsive--xl--PaddingRight);
--#{$table}__expandable-row-content--responsive--PaddingLeft: var(--#{$table}__expandable-row-content--responsive--xl--PaddingLeft);
}

// Check
--#{$table}__check--responsive--MarginLeft: var(--#{$pf-global}--spacer--sm);
--#{$table}__check--responsive--MarginLeft: var(--pf-t--global--border--width--divider--default);
--#{$table}__check--responsive--MarginTop: #{pf-size-prem(14px)};

// Favorite
Expand Down