feat(Drawer): consumed Penta tokens #6183
Conversation
| ``` | ||
|
|
||
| ### Modified panel padding | ||
| ### Modified panel body padding |
There was a problem hiding this comment.
Is this a valid use of the pf-m-padding class that we want to showcase? I updated the example to show one way to use the class on panel body content (previously this example wasn't any different from a basic drawer example), but in React we don't have a prop to apply the class on a DrawerPanelBody (though the class could be manually passed in if a consumer knew it could be used).
|
Preview: https://patternfly-pr-6183.surge.sh A11y report: https://patternfly-pr-6183-a11y.surge.sh |
|
Actually, no border radius 😄 |
|
For the resizeable panel, it would be good to keep the border that separates the sizer from the text, same as in the inline resizeable. |
3ab68b8 to
c1fc305
Compare
srambach
left a comment
There was a problem hiding this comment.
Corners and splitter look great now!
| order: 0; | ||
|
|
||
| // background-color: var(--#{$drawer}__content--BackgroundColor); | ||
| background-color: var(--#{$drawer}__content--BackgroundColor); |
There was a problem hiding this comment.
@lboehling noticed in some of the full page examples, we've lost the rounded corners around the page main content area. For example, from https://patternfly-pr-6183.surge.sh/components/drawer/html-demos/expanded-bottom/
The rounded corners are on .pf-v5-c-page__main, but in these full page examples, .pf-v5-c-page__main is a child of .pf-v5-c-drawer__content, which has this background color added and keeps the corners on page__main from showing up. Opened #6225 to try and address that, since we probably need to test a bit and see what the ideal solution is there.
There was a problem hiding this comment.
Thanks for filing this issue @mcoker
Lots of products are using drawer in this way so definitely important to fix.
andrew-ronaldson
left a comment
There was a problem hiding this comment.
Apart from the full page example Coker pointed out I think this first round is ready. Thanks!
|
🎉 This PR is included in version 6.0.0-alpha.63 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Work towards #5711