fix(charts): add tokens #6644
Merged
fix(charts): add tokens #6644
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Preview: https://patternfly-pr-6644.surge.sh A11y report: https://patternfly-pr-6644-a11y.surge.sh |
srambach
approved these changes
May 13, 2024
Member
srambach
left a comment
There was a problem hiding this comment.
Looks good on manual inspection 👀
Collaborator
|
🎉 This PR is included in version 6.0.0-alpha.131 🎉 The release is available on: Your semantic-release bot 📦🚀 |
mattnolting
pushed a commit
to mattnolting/patternfly
that referenced
this pull request
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #5949
There is an issue with some of the charts tokens not being generated because of their "string" type not supported in the exporter, but that should be fixed soon. This PR only references tokens that are generated, so we'll need a follow up once those tokens are available.
I don't know that there is much to verify for now[1] since I don't believe we can pull this change into react yet. Here is the original PR that took out the charts scss/global vars if anyone wants to reference that - https://github.com/patternfly/patternfly/pull/6533/files