fix(scss): updated to current scss spec, updated deps #7150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcoker
reviewed
Oct 17, 2024
Contributor
There was a problem hiding this comment.
Not quite done with the review, but wanted to leave a comment:
- I had a question below
- Looks like I don't have permission to view the backstop report
- created a diff report of patternfly.css from this PR and on main (https://www.diffchecker.com/4ZIWu5tj/)
- looks like the build is failing possibly from this error "error [email protected]: The engine "node" is incompatible with this module. Expected version "20 || >=22". Got "18.20.4"
" @dlabaj wdyt about the build failure?
Comment on lines
+753
to
+767
| .#{$drawer} { | ||
| @include pf-v6-bidirectional-style( | ||
| $prop: --#{$drawer}--m-expanded__panel--BoxShadow, | ||
| $ltr-val: var(--pf-t--global--box-shadow--md--left), | ||
| $rtl-val: var(--pf-t--global--box-shadow--md--right) | ||
| ); | ||
| } | ||
|
|
||
| .#{$drawer} { | ||
| @include pf-v6-bidirectional-style( | ||
| $prop: --#{$drawer}--m-expanded--m-panel-left__panel--BoxShadow, | ||
| $ltr-val: var(--pf-t--global--box-shadow--md--right), | ||
| $rtl-val: var(--pf-t--global--box-shadow--md--left) | ||
| ); | ||
| } |
Contributor
There was a problem hiding this comment.
Curious why these aren't under the existing drawer selector? And whey they're in separate selectors?
|
This PR has been automatically marked as stale because it has not had activity in the last 60 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #6916
TLDR
Our sass configuration and dependencies are deprecated. There are several issues throwing build errors.
@includestatements at the top of CSS declaration blocksrenderSync()function compilation functionmap-get()->map.get(),type-of()->list.type-of(), etc)This PR:
@media,@include,renderSync()tosass.compile()Looks like we need to update backstop refs. Here's the current regression report. Backstop report