-
Notifications
You must be signed in to change notification settings - Fork 105
fix: fixes broken links #8008
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fixes broken links #8008
Conversation
|
Preview: https://pf-pr-8008.surge.sh A11y report: https://pf-pr-8008-a11y.surge.sh |
mcoker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks!
| These text utilities can be used to modify text within the PatternFly framework. In most cases, using the components with available modifiers should be sufficient to implement most designs, and should be preferred over customizations using these utilities. | ||
|
|
||
| Care should be taken especially when applying text colors, as this can have a negative effect on the readability and accessibility of text. Refer to the information on [contrast ratios](/guidelines/colors/#contrast-ratios) for more information. | ||
| Care should be taken especially when applying text colors, as this can have a negative effect on the readability and accessibility of text. Refer to the information on [contrast ratios](/foundations-and-styles/colors/#contrast-ratios) for more information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if it matters because the link you provided works, but it's in a slightly different format that I'd expect. FWIW if I go to staging (nothing else in the url), then just navigate to the colors section, both the link in the jump links for "contrast ratios" and the little link icon next to the "contrast ratios" section title give me the format below, without the / before the #.
| Care should be taken especially when applying text colors, as this can have a negative effect on the readability and accessibility of text. Refer to the information on [contrast ratios](/foundations-and-styles/colors/#contrast-ratios) for more information. | |
| Care should be taken especially when applying text colors, as this can have a negative effect on the readability and accessibility of text. Refer to the information on [contrast ratios](/foundations-and-styles/colors#contrast-ratios) for more information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll submit another PR to update this and fix a few more broken links I found that are not related to any of the nav updates.
|
🎉 This PR is included in version 6.5.0-prerelease.29 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Core counterpart to patternfly/patternfly-org#4882 to update a few broken links resulting from the nav redesign