chore(backstop): update baseline #8076
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (122)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including You can disable this status message by setting the
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Collaborator
|
Preview: https://pf-pr-8076.surge.sh A11y report: https://pf-pr-8076-a11y.surge.sh |
mcoker
approved these changes
Jan 28, 2026
Contributor
mcoker
left a comment
There was a problem hiding this comment.
LGTM. I'm assuming the border--width--box--clicked change is on purpose - now default/hover/clicked are all unique widths.
- --pf-t--global--border--width--box--clicked: var(--pf-t--global--border--width--200);
+ --pf-t--global--border--width--box--clicked: var(--pf-t--global--border--width--300);
--pf-t--global--border--width--box--default: var(--pf-t--global--border--width--100);
- --pf-t--global--border--width--box--hover: var(--pf-t--global--border--width--100);
+ --pf-t--global--border--width--box--hover: var(--pf-t--global--border--width--200);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Diffs shown in report
I see a lot of on-disabled, a border change in cards, and backdrop color.
See changes in https://github.com/patternfly/patternfly/pull/8062/changes#diff-bdf0e7fecf8c9f7b350a2936aa70c255f25271ddd9d1df9b552f2ebfb303152f