src/utils/icons/reactIcons.ts (3)

50-54: Static analysis ReDoS warning is a false positive in this context.

The regex at line 51 is constructed from setId values that originate from IconsManifest (react-icons library internal data), not from user input. The pattern ^${setPrefix} is a simple anchored prefix match without problematic quantifiers, making ReDoS practically impossible here.

However, if you want to be extra defensive, you could sanitize the input or use a literal string match instead:

♻️ Optional: Use string operations instead of regex

   } else {
     const setPrefix = setId.charAt(0).toUpperCase() + setId.slice(1)
-    const prefix = new RegExp(`^${setPrefix}`, 'i')
-    base = base.replace(prefix, '')
+    if (base.toLowerCase().startsWith(setPrefix.toLowerCase())) {
+      base = base.slice(setPrefix.length)
+    }
   }

---

82-84: Consider logging failed icon set loads for debugging.

Silent failures make troubleshooting difficult. While graceful degradation is appropriate, logging would help identify issues during development or when icon sets are unexpectedly unavailable.

♻️ Optional: Add debug logging

-    } catch {
-      // Skip sets that fail to load
+    } catch (error) {
+      // Skip sets that fail to load, but log for debugging
+      console.debug(`Failed to load icon set '${setId}':`, error)
     }

---

62-88: Consider caching getAllIcons() result to avoid repeated dynamic imports.

getAllIcons() performs dynamic imports for every icon set on each call. For a production API, this could be expensive if called frequently. Consider memoizing the result since icon sets don't change at runtime.

♻️ Proposed caching implementation

+let cachedIcons: IconMetadata[] | null = null
+
 export async function getAllIcons(): Promise<IconMetadata[]> {
+  if (cachedIcons) {
+    return cachedIcons
+  }
+
   const icons: IconMetadata[] = []

   for (const setId of ICON_SET_IDS) {
     // ... existing code ...
   }

+  cachedIcons = icons
   return icons
 }

src/__tests__/pages/api/__tests__/[version]/icons/[iconName].test.ts (1)

17-24: Mock duplicates production logic - consider importing the real function.

The parseIconId mock reimplements the actual logic, which could lead to test/implementation drift. Consider using Jest's requireActual to import the real function while mocking only what's necessary.

♻️ Proposed: Use real parseIconId implementation

 jest.mock('../../../../../../utils/icons/reactIcons', () => ({
   getIconSvg: jest.fn((setId: string, iconName: string) => {
     if (setId === 'fa' && iconName === 'FaCircle') return Promise.resolve(mockSvg)
     return Promise.resolve(null)
   }),
-  parseIconId: jest.fn((iconId: string) => {
-    const underscoreIndex = iconId.indexOf('_')
-    if (underscoreIndex <= 0) return null
-    const setId = iconId.slice(0, underscoreIndex)
-    const iconName = iconId.slice(underscoreIndex + 1)
-    if (!setId || !iconName) return null
-    return { setId, iconName }
-  }),
+  parseIconId: jest.requireActual('../../../../../../utils/icons/reactIcons').parseIconId,
 }))

src/pages/api/openapi.json.ts (2)

107-163: Consider adding 404 response for version not found.

The /{version}/icons endpoint returns 404 when the version doesn't exist (per the implementation in src/pages/api/[version]/icons/index.ts), but this isn't documented in the OpenAPI spec.

📝 Add 404 response documentation

             '200': {
               description: 'List of icons with metadata',
               // ... existing schema ...
             },
+            '404': {
+              description: 'Version not found',
+            },
           },

---

164-201: Consider adding 400 response for invalid icon name format.

The /{version}/icons/{icon-name} endpoint returns 400 for invalid icon name formats, but only 404 is documented. This could cause confusion for API consumers.

📝 Add 400 response documentation

           responses: {
             '200': {
               description: 'SVG markup for the icon',
               content: {
                 'image/svg+xml': {
                   schema: { type: 'string' },
                 },
               },
             },
+            '400': {
+              description: 'Invalid icon name format. Expected: {set}_{iconName}',
+            },
             '404': {
               description: 'Icon not found',
             },
           },

src/pages/api/[version]/icons/[iconName].ts (1)

17-17: Minor: Variable aliasing may cause confusion.

The destructuring { version, iconName: iconId } creates an alias, but iconName is reused later (line 53) as a different variable from parseIconId. While not a bug, this could be clearer.

♻️ Suggested clarification

Consider renaming for clarity:

-  const { version, iconName: iconId } = params
+  const { version, iconName: rawIconId } = params

And update references to iconId → rawIconId accordingly.

src/__tests__/pages/api/__tests__/[version]/icons/index.test.ts (1)

50-51: Consider using describe block and afterEach for cleaner test organization.

Tests would benefit from wrapping in a describe block and moving the repeated jest.restoreAllMocks() calls to an afterEach hook.

♻️ Suggested structure

+describe('GET /api/{version}/icons', () => {
+  afterEach(() => {
+    jest.restoreAllMocks()
+  })
+
 it('returns all icons with metadata', async () => {
   global.fetch = jest.fn(() =>
     ...
   expect(body.icons[0]).toHaveProperty('unicode')
-
-  jest.restoreAllMocks()
 })
 // ... other tests without individual restoreAllMocks calls
+})

Also applies to: 79-80

src/pages/api/[version]/icons/index.ts (1)

32-33: Consider pagination for large icon sets.

react-icons contains thousands of icons across all sets. Returning all icons in a single response could impact performance and client-side rendering. Consider adding pagination (limit/offset or cursor-based) for production use.