chore(build): address linting rule violations#9396
Merged
nicolethoen merged 3 commits intopatternfly:mainfrom Aug 9, 2023
Merged
chore(build): address linting rule violations#9396nicolethoen merged 3 commits intopatternfly:mainfrom
nicolethoen merged 3 commits intopatternfly:mainfrom
Conversation
Collaborator
|
Preview: https://patternfly-react-pr-9396.surge.sh A11y report: https://patternfly-react-pr-9396-a11y.surge.sh |
Contributor
thatblindgeye
left a comment
There was a problem hiding this comment.
Just a couple quick questions below
nicolethoen
approved these changes
Aug 3, 2023
Contributor
nicolethoen
left a comment
There was a problem hiding this comment.
does linting fail if you revert the two changes that Eric noted? I would definitely wonder why that's the case in only those two files...
Otherwise, this LGTM
bda625b to
9ad092d
Compare
1 task
jenny-s51
commented
Aug 8, 2023
Contributor
Author
There was a problem hiding this comment.
Thanks @thatblindgeye @nicolethoen - reverted. The only outstanding linting error is an incompatibility issue with Prettier versions, should be fixed once #9473 is merged
fix styling test errors disable rule enable rule try moving export update class component exports fix table export fix test fix linting errors PR feedback from Eric
thatblindgeye
approved these changes
Aug 8, 2023
nicolethoen
pushed a commit
to Kells512/patternfly-react
that referenced
this pull request
Sep 1, 2023
* WIP ESlint errors fix styling test errors disable rule enable rule try moving export update class component exports fix table export fix test fix linting errors PR feedback from Eric * revert remove displayName and fix lint issues * fix lint error in test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Closes #8657 and #8658
Re-enabled no-anonymous-functions and prettier. Fixes linting violations and errors thrown by no-anonymous-functions rule.
Outside of this issue we may want to have a larger discussion about any modifications we may want to make to
.eslintrc.jsonand how to align the best practices with PF needs cc @nicolethoen