chore(NotificationDrawer): demo conversion from JS to TS#9516
chore(NotificationDrawer): demo conversion from JS to TS#9516tlabaj merged 7 commits intopatternfly:mainfrom
Conversation
|
Preview: https://patternfly-react-pr-9516.surge.sh A11y report: https://patternfly-react-pr-9516-a11y.surge.sh |
|
I cannot figure out why the ts -> js button is not appearing in the second demo and the site doesn't seem to think the second demo is written in ts... still looking into it, but maybe someone else here knows? |
thatblindgeye
left a comment
There was a problem hiding this comment.
Haven't looked into the above issue that Nicole mentioned, but I'd imagine we could update the js file=... to ts file=... in the MD file. Do you get the same issue as the Nav demo PR when doing so?
packages/react-core/src/demos/NotificationDrawer/examples/NotificationDrawerGrouped.tsx
Outdated
Show resolved
Hide resolved
packages/react-core/src/demos/NotificationDrawer/examples/NotificationDrawerBasic.tsx
Outdated
Show resolved
Hide resolved
packages/react-core/src/demos/NotificationDrawer/examples/NotificationDrawerBasic.tsx
Outdated
Show resolved
Hide resolved
|
@nicolethoen I wonder if it's just an issue with the preview... I tried editing my Org clone locally to add in the tsx example files to react-core (using |
|
Maybe a rebase/rebuild would iron out the surge? |
nicolethoen
left a comment
There was a problem hiding this comment.
looks like its all working now!
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
What: Closes #9438