Codestin Search App

mcoker · 2023-09-12T03:11:08Z

This may not be a great way to do this, but these are basically drillup items in the breadcrumb menus.

patternfly-build · 2023-09-12T03:19:44Z

Preview: https://patternfly-react-pr-9603.surge.sh

A11y report: https://patternfly-react-pr-9603-a11y.surge.sh

thatblindgeye

One issue with using the direction prop for the icon is that it's also going to set some other code internal to MenuItem that isn't needed:

patternfly-react/packages/react-core/src/components/Menu/MenuItem.tsx

Lines 249 to 265 in 1d53917

    
           let drill: (event: React.KeyboardEvent | React.MouseEvent) => void; 
        
           if (direction) { 
        
             if (direction === 'down') { 
        
               drill = (event) => 
        
                 onDrillIn && 
        
                 onDrillIn( 
        
                   event, 
        
                   menuId, 
        
                   typeof drilldownMenu === 'function' 
        
                     ? (drilldownMenu() as any).props.id 
        
                     : (drilldownMenu as React.ReactElement).props.id, 
        
                   itemId 
        
                 ); 
        
             } else { 
        
               drill = (event) => onDrillOut && onDrillOut(event, parentMenu, itemId); 
        
             } 
        
           }

When it's used in Menu, it's also used for a drilldown type of menu, where the item leads to another sub-menu or a parent menu. For these breadcrumbs, it's more just selecting an item within a list that has been truncated to save space, rather than leading to a sub or parent menu.

This may be a case to use the modifier class to mirror the icon in the examples.

thatblindgeye · 2023-09-18T20:35:05Z

If we wanted to utilize the direction prop to render the icon correctly, we could update the logic inside of Menu around the code lines I linked above so that we're only reassigning the drill variable if direction && (onDrillIn || onDrillOut).

Overall I dont think I feel too strongly if we want to get this in, though. Unless a user is also passing either of those onDrill callbacks in it may not ultimately matter.

mcoker · 2023-09-18T23:50:15Z

@thatblindgeye we could close this PR (and the core PR) and leave the issues open, and we can work on it after the release or in a breaking change release if that's needed. WDYT? On the core side, I think it's just going to be updating the examples to wrap the icon in the menu__item-toggle-icon element.

thatblindgeye · 2023-09-19T12:25:16Z

@mcoker Unless anyone else feels it's urgent to fix I'd be fine with that. As it is it could be considered more the example issue rather than an issue with the component.

wise-king-sullyman · 2023-09-19T14:18:22Z

That sounds like a great plan to me as well.

tlabaj

Did we decide we were nit going to make any changes to fix example code to work with RTL since this would be consumer provided? Maybe this belongs in handbook.

mcoker · 2023-09-20T16:51:08Z

@tlabaj great question 😅. We have updated a few examples, most cases from what I recall are with code that really should be built into our component. For random icons and things included as filler in components, I believe we've just left all of those alone.

This PR is an example of something a menu item should support. Another example is the expand all icon used in a <ToolbarItem variation="expand-all">.

There are issues for both of these to update our components to support making RTL work natively

The issue this PR addresses - Menu/MenuItem - should support drill-[up/out] icon/layout in menu list #9653
Toolbar expand-all icon ToolbarItem - expand-all variant should include expand all icon #9641

patternfly-build · 2023-09-21T14:12:29Z

Your changes have been released in:

Thanks for your contribution! 🎉

* refactor(SliderStep): use token instead for hardcoded value (#9651) * feat(Drawer): Added start and end to position props, updated resizing to work with RTL (#9627) * feat(Drawer): Added start and end to position props, updaed resizing to work with RTL * update logic for newsize * fix(Modal): Prevent duplicate ids within Modal (#9555) * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * chore(Brand): update tests (#9543) * chore(Brand): update tests * add more tests * add width test * test updates * feat(Select) - add appendTo to SelectPopperProps (#9578) * fix(misc): fixed broken CodeSandbox demos (#9519) * update import paths * fix(table): update data imports to absolute * fix remaining codesandbox demos * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * chore: update breadcrumb dropdown item arrow to work in RTL (#9603) * chore: update breadcrumb dropdown item arrow to work in RTL * chore: use icon with shouldMirrorRTL instead * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * fix(Slider): Updated slider to work in RTL. (#9655) * fix(Slider): Updred slider to work in RTL. Deprecated rightActions and leftActions props, added endActions and startActions props. * fixes from comments * docs(Toolbar): remove test example (#9614) * docs(tabs): Clean up React documentation content. (#9606) * docs(tabs):clean up React documentation content. * Update packages/react-core/src/components/Tabs/examples/Tabs.md * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * fix(popper): add start/end positioning with RTL support, update default (#9628) * fix(popper): add start/end positioning with RTL support, update default * ensure that getLanguageDirection only returns ltr or rtl * fix(Popper): expanded types to include start/end; updated position value * fix(Dropdown): Add appendTo to dropdownPopperProps interface (#9635) * feat(Timestamp): allowed displayed datetime to be UTC (#9649) * feat(Timestamp): allowed displayed datetime to be UTC * Updated rendering of default UTC suffix * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * chore(deps): update dependency @patternfly/patternfly to v5.1.0-prerelease.32 (#9642) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(Tabs): allow RTL scrolling (#9633) * fix(Tabs): allow RTL scrolling * add direction assignment to update * update aria label descriptions * add props and deprecate old, update internal state names * update desc * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] * fix(Nav): allow RTL scrolling (#9637) * fix(Nav): allow rtl scrolling * add direction assignment to update * update aria label descriptions * add new props and deprecate old * update desc * update other test snaps * chore(BackgroundImage): update tests (#9584) * chore(BackgroundImage): update tests * add spread prop test, update test * use styles obj * update test name to use styles * feat(Label) add option to make label clickable (#9284) * feat(Label) add option to make label clickable * add type to label button * chore(Label): Address misc PR feedback * chore(Label): Remove mention of onClick being incompatible with overflow * chore(Label): Remove prop from effect deps where it's no longer needed --------- Co-authored-by: Austin Sullivan <[email protected]> * feat(charts): add RTL legend support (#9570) * feat(charts): add RTL legend support * clone data/label components * remove legend positions, add beta * remove last position update * update logic to account for text length * update clones * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * fix(PrimaryDetail): remove primary detail card view require statement (#9661) * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * fix(Draggable): dont disable droppable on false ondrag (#9646) * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * chore(screenshots): Updated screenshots (#9660) * chore(screenshots): Updated screenshots * rebase and update * fix: dry run publishing v6 alphas --------- Co-authored-by: adamviktora <[email protected]> Co-authored-by: Titani Labaj <[email protected]> Co-authored-by: Austin Sullivan <[email protected]> Co-authored-by: patternfly-build <[email protected]> Co-authored-by: kmcfaul <[email protected]> Co-authored-by: Maria <[email protected]> Co-authored-by: Jenny <[email protected]> Co-authored-by: Michael Coker <[email protected]> Co-authored-by: Erin Donehoo <[email protected]> Co-authored-by: Eric Olkowski <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Dominik Petřík <[email protected]> Co-authored-by: Dallas <[email protected]>

* refactor(SliderStep): use token instead for hardcoded value (patternfly#9651) * feat(Drawer): Added start and end to position props, updated resizing to work with RTL (patternfly#9627) * feat(Drawer): Added start and end to position props, updaed resizing to work with RTL * update logic for newsize * fix(Modal): Prevent duplicate ids within Modal (patternfly#9555) * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * chore(Brand): update tests (patternfly#9543) * chore(Brand): update tests * add more tests * add width test * test updates * feat(Select) - add appendTo to SelectPopperProps (patternfly#9578) * fix(misc): fixed broken CodeSandbox demos (patternfly#9519) * update import paths * fix(table): update data imports to absolute * fix remaining codesandbox demos * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * chore: update breadcrumb dropdown item arrow to work in RTL (patternfly#9603) * chore: update breadcrumb dropdown item arrow to work in RTL * chore: use icon with shouldMirrorRTL instead * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * fix(Slider): Updated slider to work in RTL. (patternfly#9655) * fix(Slider): Updred slider to work in RTL. Deprecated rightActions and leftActions props, added endActions and startActions props. * fixes from comments * docs(Toolbar): remove test example (patternfly#9614) * docs(tabs): Clean up React documentation content. (patternfly#9606) * docs(tabs):clean up React documentation content. * Update packages/react-core/src/components/Tabs/examples/Tabs.md * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * fix(popper): add start/end positioning with RTL support, update default (patternfly#9628) * fix(popper): add start/end positioning with RTL support, update default * ensure that getLanguageDirection only returns ltr or rtl * fix(Popper): expanded types to include start/end; updated position value * fix(Dropdown): Add appendTo to dropdownPopperProps interface (patternfly#9635) * feat(Timestamp): allowed displayed datetime to be UTC (patternfly#9649) * feat(Timestamp): allowed displayed datetime to be UTC * Updated rendering of default UTC suffix * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * chore(deps): update dependency @patternfly/patternfly to v5.1.0-prerelease.32 (patternfly#9642) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(Tabs): allow RTL scrolling (patternfly#9633) * fix(Tabs): allow RTL scrolling * add direction assignment to update * update aria label descriptions * add props and deprecate old, update internal state names * update desc * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] * fix(Nav): allow RTL scrolling (patternfly#9637) * fix(Nav): allow rtl scrolling * add direction assignment to update * update aria label descriptions * add new props and deprecate old * update desc * update other test snaps * chore(BackgroundImage): update tests (patternfly#9584) * chore(BackgroundImage): update tests * add spread prop test, update test * use styles obj * update test name to use styles * feat(Label) add option to make label clickable (patternfly#9284) * feat(Label) add option to make label clickable * add type to label button * chore(Label): Address misc PR feedback * chore(Label): Remove mention of onClick being incompatible with overflow * chore(Label): Remove prop from effect deps where it's no longer needed --------- Co-authored-by: Austin Sullivan <[email protected]> * feat(charts): add RTL legend support (patternfly#9570) * feat(charts): add RTL legend support * clone data/label components * remove legend positions, add beta * remove last position update * update logic to account for text length * update clones * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * fix(PrimaryDetail): remove primary detail card view require statement (patternfly#9661) * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * fix(Draggable): dont disable droppable on false ondrag (patternfly#9646) * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * chore(screenshots): Updated screenshots (patternfly#9660) * chore(screenshots): Updated screenshots * rebase and update * fix: dry run publishing v6 alphas --------- Co-authored-by: adamviktora <[email protected]> Co-authored-by: Titani Labaj <[email protected]> Co-authored-by: Austin Sullivan <[email protected]> Co-authored-by: patternfly-build <[email protected]> Co-authored-by: kmcfaul <[email protected]> Co-authored-by: Maria <[email protected]> Co-authored-by: Jenny <[email protected]> Co-authored-by: Michael Coker <[email protected]> Co-authored-by: Erin Donehoo <[email protected]> Co-authored-by: Eric Olkowski <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Dominik Petřík <[email protected]> Co-authored-by: Dallas <[email protected]>

* refactor(SliderStep): use token instead for hardcoded value (#9651) * feat(Drawer): Added start and end to position props, updated resizing to work with RTL (#9627) * feat(Drawer): Added start and end to position props, updaed resizing to work with RTL * update logic for newsize * fix(Modal): Prevent duplicate ids within Modal (#9555) * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * chore(Brand): update tests (#9543) * chore(Brand): update tests * add more tests * add width test * test updates * feat(Select) - add appendTo to SelectPopperProps (#9578) * fix(misc): fixed broken CodeSandbox demos (#9519) * update import paths * fix(table): update data imports to absolute * fix remaining codesandbox demos * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * chore: update breadcrumb dropdown item arrow to work in RTL (#9603) * chore: update breadcrumb dropdown item arrow to work in RTL * chore: use icon with shouldMirrorRTL instead * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * fix(Slider): Updated slider to work in RTL. (#9655) * fix(Slider): Updred slider to work in RTL. Deprecated rightActions and leftActions props, added endActions and startActions props. * fixes from comments * docs(Toolbar): remove test example (#9614) * docs(tabs): Clean up React documentation content. (#9606) * docs(tabs):clean up React documentation content. * Update packages/react-core/src/components/Tabs/examples/Tabs.md * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * fix(popper): add start/end positioning with RTL support, update default (#9628) * fix(popper): add start/end positioning with RTL support, update default * ensure that getLanguageDirection only returns ltr or rtl * fix(Popper): expanded types to include start/end; updated position value * fix(Dropdown): Add appendTo to dropdownPopperProps interface (#9635) * feat(Timestamp): allowed displayed datetime to be UTC (#9649) * feat(Timestamp): allowed displayed datetime to be UTC * Updated rendering of default UTC suffix * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * chore(deps): update dependency @patternfly/patternfly to v5.1.0-prerelease.32 (#9642) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(Tabs): allow RTL scrolling (#9633) * fix(Tabs): allow RTL scrolling * add direction assignment to update * update aria label descriptions * add props and deprecate old, update internal state names * update desc * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] * fix(Nav): allow RTL scrolling (#9637) * fix(Nav): allow rtl scrolling * add direction assignment to update * update aria label descriptions * add new props and deprecate old * update desc * update other test snaps * chore(BackgroundImage): update tests (#9584) * chore(BackgroundImage): update tests * add spread prop test, update test * use styles obj * update test name to use styles * feat(Label) add option to make label clickable (#9284) * feat(Label) add option to make label clickable * add type to label button * chore(Label): Address misc PR feedback * chore(Label): Remove mention of onClick being incompatible with overflow * chore(Label): Remove prop from effect deps where it's no longer needed --------- Co-authored-by: Austin Sullivan <[email protected]> * feat(charts): add RTL legend support (#9570) * feat(charts): add RTL legend support * clone data/label components * remove legend positions, add beta * remove last position update * update logic to account for text length * update clones * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * fix(PrimaryDetail): remove primary detail card view require statement (#9661) * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * fix(Draggable): dont disable droppable on false ondrag (#9646) * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * chore(screenshots): Updated screenshots (#9660) * chore(screenshots): Updated screenshots * rebase and update * Revert "chore(deps): update dependency ts-patch to v3 (#9271)" (#9701) This reverts commit 03985a2. * chore(release): releasing packages [ci skip] - @patternfly/[email protected] * fix: white space change to trigger new prereleases [skip-a11y] * fix: whitespace changes to trigger prereleases (#9702) * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] * fix: Release alphas from v6 and rebase from main (#9692) * refactor(SliderStep): use token instead for hardcoded value (#9651) * feat(Drawer): Added start and end to position props, updated resizing to work with RTL (#9627) * feat(Drawer): Added start and end to position props, updaed resizing to work with RTL * update logic for newsize * fix(Modal): Prevent duplicate ids within Modal (#9555) * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * chore(Brand): update tests (#9543) * chore(Brand): update tests * add more tests * add width test * test updates * feat(Select) - add appendTo to SelectPopperProps (#9578) * fix(misc): fixed broken CodeSandbox demos (#9519) * update import paths * fix(table): update data imports to absolute * fix remaining codesandbox demos * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * chore: update breadcrumb dropdown item arrow to work in RTL (#9603) * chore: update breadcrumb dropdown item arrow to work in RTL * chore: use icon with shouldMirrorRTL instead * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * fix(Slider): Updated slider to work in RTL. (#9655) * fix(Slider): Updred slider to work in RTL. Deprecated rightActions and leftActions props, added endActions and startActions props. * fixes from comments * docs(Toolbar): remove test example (#9614) * docs(tabs): Clean up React documentation content. (#9606) * docs(tabs):clean up React documentation content. * Update packages/react-core/src/components/Tabs/examples/Tabs.md * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * fix(popper): add start/end positioning with RTL support, update default (#9628) * fix(popper): add start/end positioning with RTL support, update default * ensure that getLanguageDirection only returns ltr or rtl * fix(Popper): expanded types to include start/end; updated position value * fix(Dropdown): Add appendTo to dropdownPopperProps interface (#9635) * feat(Timestamp): allowed displayed datetime to be UTC (#9649) * feat(Timestamp): allowed displayed datetime to be UTC * Updated rendering of default UTC suffix * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * chore(deps): update dependency @patternfly/patternfly to v5.1.0-prerelease.32 (#9642) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(Tabs): allow RTL scrolling (#9633) * fix(Tabs): allow RTL scrolling * add direction assignment to update * update aria label descriptions * add props and deprecate old, update internal state names * update desc * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] * fix(Nav): allow RTL scrolling (#9637) * fix(Nav): allow rtl scrolling * add direction assignment to update * update aria label descriptions * add new props and deprecate old * update desc * update other test snaps * chore(BackgroundImage): update tests (#9584) * chore(BackgroundImage): update tests * add spread prop test, update test * use styles obj * update test name to use styles * feat(Label) add option to make label clickable (#9284) * feat(Label) add option to make label clickable * add type to label button * chore(Label): Address misc PR feedback * chore(Label): Remove mention of onClick being incompatible with overflow * chore(Label): Remove prop from effect deps where it's no longer needed --------- Co-authored-by: Austin Sullivan <[email protected]> * feat(charts): add RTL legend support (#9570) * feat(charts): add RTL legend support * clone data/label components * remove legend positions, add beta * remove last position update * update logic to account for text length * update clones * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * fix(PrimaryDetail): remove primary detail card view require statement (#9661) * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * fix(Draggable): dont disable droppable on false ondrag (#9646) * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * chore(screenshots): Updated screenshots (#9660) * chore(screenshots): Updated screenshots * rebase and update * fix: dry run publishing v6 alphas --------- Co-authored-by: adamviktora <[email protected]> Co-authored-by: Titani Labaj <[email protected]> Co-authored-by: Austin Sullivan <[email protected]> Co-authored-by: patternfly-build <[email protected]> Co-authored-by: kmcfaul <[email protected]> Co-authored-by: Maria <[email protected]> Co-authored-by: Jenny <[email protected]> Co-authored-by: Michael Coker <[email protected]> Co-authored-by: Erin Donehoo <[email protected]> Co-authored-by: Eric Olkowski <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Dominik Petřík <[email protected]> Co-authored-by: Dallas <[email protected]> * fix: whitespace change to try out dryrun * fix: remove --no-private with dryrun [skip-a11y] * fix: turn off dry run and release alphas [skip-a11y] * chore(release): releasing packages [ci skip] - [email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] --------- Co-authored-by: adamviktora <[email protected]> Co-authored-by: Austin Sullivan <[email protected]> Co-authored-by: patternfly-build <[email protected]> Co-authored-by: kmcfaul <[email protected]> Co-authored-by: Maria <[email protected]> Co-authored-by: Jenny <[email protected]> Co-authored-by: Michael Coker <[email protected]> Co-authored-by: Erin Donehoo <[email protected]> Co-authored-by: Eric Olkowski <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Dominik Petřík <[email protected]> Co-authored-by: Dallas <[email protected]> Co-authored-by: Nicole Thoen <[email protected]>

* refactor(SliderStep): use token instead for hardcoded value (patternfly#9651) * feat(Drawer): Added start and end to position props, updated resizing to work with RTL (patternfly#9627) * feat(Drawer): Added start and end to position props, updaed resizing to work with RTL * update logic for newsize * fix(Modal): Prevent duplicate ids within Modal (patternfly#9555) * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * chore(Brand): update tests (patternfly#9543) * chore(Brand): update tests * add more tests * add width test * test updates * feat(Select) - add appendTo to SelectPopperProps (patternfly#9578) * fix(misc): fixed broken CodeSandbox demos (patternfly#9519) * update import paths * fix(table): update data imports to absolute * fix remaining codesandbox demos * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * chore: update breadcrumb dropdown item arrow to work in RTL (patternfly#9603) * chore: update breadcrumb dropdown item arrow to work in RTL * chore: use icon with shouldMirrorRTL instead * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * fix(Slider): Updated slider to work in RTL. (patternfly#9655) * fix(Slider): Updred slider to work in RTL. Deprecated rightActions and leftActions props, added endActions and startActions props. * fixes from comments * docs(Toolbar): remove test example (patternfly#9614) * docs(tabs): Clean up React documentation content. (patternfly#9606) * docs(tabs):clean up React documentation content. * Update packages/react-core/src/components/Tabs/examples/Tabs.md * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * fix(popper): add start/end positioning with RTL support, update default (patternfly#9628) * fix(popper): add start/end positioning with RTL support, update default * ensure that getLanguageDirection only returns ltr or rtl * fix(Popper): expanded types to include start/end; updated position value * fix(Dropdown): Add appendTo to dropdownPopperProps interface (patternfly#9635) * feat(Timestamp): allowed displayed datetime to be UTC (patternfly#9649) * feat(Timestamp): allowed displayed datetime to be UTC * Updated rendering of default UTC suffix * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * chore(deps): update dependency @patternfly/patternfly to v5.1.0-prerelease.32 (patternfly#9642) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(Tabs): allow RTL scrolling (patternfly#9633) * fix(Tabs): allow RTL scrolling * add direction assignment to update * update aria label descriptions * add props and deprecate old, update internal state names * update desc * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] * fix(Nav): allow RTL scrolling (patternfly#9637) * fix(Nav): allow rtl scrolling * add direction assignment to update * update aria label descriptions * add new props and deprecate old * update desc * update other test snaps * chore(BackgroundImage): update tests (patternfly#9584) * chore(BackgroundImage): update tests * add spread prop test, update test * use styles obj * update test name to use styles * feat(Label) add option to make label clickable (patternfly#9284) * feat(Label) add option to make label clickable * add type to label button * chore(Label): Address misc PR feedback * chore(Label): Remove mention of onClick being incompatible with overflow * chore(Label): Remove prop from effect deps where it's no longer needed --------- Co-authored-by: Austin Sullivan <[email protected]> * feat(charts): add RTL legend support (patternfly#9570) * feat(charts): add RTL legend support * clone data/label components * remove legend positions, add beta * remove last position update * update logic to account for text length * update clones * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * fix(PrimaryDetail): remove primary detail card view require statement (patternfly#9661) * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * fix(Draggable): dont disable droppable on false ondrag (patternfly#9646) * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * chore(screenshots): Updated screenshots (patternfly#9660) * chore(screenshots): Updated screenshots * rebase and update * fix: dry run publishing v6 alphas --------- Co-authored-by: adamviktora <[email protected]> Co-authored-by: Titani Labaj <[email protected]> Co-authored-by: Austin Sullivan <[email protected]> Co-authored-by: patternfly-build <[email protected]> Co-authored-by: kmcfaul <[email protected]> Co-authored-by: Maria <[email protected]> Co-authored-by: Jenny <[email protected]> Co-authored-by: Michael Coker <[email protected]> Co-authored-by: Erin Donehoo <[email protected]> Co-authored-by: Eric Olkowski <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Dominik Petřík <[email protected]> Co-authored-by: Dallas <[email protected]>

* refactor(SliderStep): use token instead for hardcoded value (patternfly#9651) * feat(Drawer): Added start and end to position props, updated resizing to work with RTL (patternfly#9627) * feat(Drawer): Added start and end to position props, updaed resizing to work with RTL * update logic for newsize * fix(Modal): Prevent duplicate ids within Modal (patternfly#9555) * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * chore(Brand): update tests (patternfly#9543) * chore(Brand): update tests * add more tests * add width test * test updates * feat(Select) - add appendTo to SelectPopperProps (patternfly#9578) * fix(misc): fixed broken CodeSandbox demos (patternfly#9519) * update import paths * fix(table): update data imports to absolute * fix remaining codesandbox demos * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * chore: update breadcrumb dropdown item arrow to work in RTL (patternfly#9603) * chore: update breadcrumb dropdown item arrow to work in RTL * chore: use icon with shouldMirrorRTL instead * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * fix(Slider): Updated slider to work in RTL. (patternfly#9655) * fix(Slider): Updred slider to work in RTL. Deprecated rightActions and leftActions props, added endActions and startActions props. * fixes from comments * docs(Toolbar): remove test example (patternfly#9614) * docs(tabs): Clean up React documentation content. (patternfly#9606) * docs(tabs):clean up React documentation content. * Update packages/react-core/src/components/Tabs/examples/Tabs.md * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * fix(popper): add start/end positioning with RTL support, update default (patternfly#9628) * fix(popper): add start/end positioning with RTL support, update default * ensure that getLanguageDirection only returns ltr or rtl * fix(Popper): expanded types to include start/end; updated position value * fix(Dropdown): Add appendTo to dropdownPopperProps interface (patternfly#9635) * feat(Timestamp): allowed displayed datetime to be UTC (patternfly#9649) * feat(Timestamp): allowed displayed datetime to be UTC * Updated rendering of default UTC suffix * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * chore(deps): update dependency @patternfly/patternfly to v5.1.0-prerelease.32 (patternfly#9642) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(Tabs): allow RTL scrolling (patternfly#9633) * fix(Tabs): allow RTL scrolling * add direction assignment to update * update aria label descriptions * add props and deprecate old, update internal state names * update desc * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] * fix(Nav): allow RTL scrolling (patternfly#9637) * fix(Nav): allow rtl scrolling * add direction assignment to update * update aria label descriptions * add new props and deprecate old * update desc * update other test snaps * chore(BackgroundImage): update tests (patternfly#9584) * chore(BackgroundImage): update tests * add spread prop test, update test * use styles obj * update test name to use styles * feat(Label) add option to make label clickable (patternfly#9284) * feat(Label) add option to make label clickable * add type to label button * chore(Label): Address misc PR feedback * chore(Label): Remove mention of onClick being incompatible with overflow * chore(Label): Remove prop from effect deps where it's no longer needed --------- Co-authored-by: Austin Sullivan <[email protected]> * feat(charts): add RTL legend support (patternfly#9570) * feat(charts): add RTL legend support * clone data/label components * remove legend positions, add beta * remove last position update * update logic to account for text length * update clones * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * fix(PrimaryDetail): remove primary detail card view require statement (patternfly#9661) * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * fix(Draggable): dont disable droppable on false ondrag (patternfly#9646) * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * chore(screenshots): Updated screenshots (patternfly#9660) * chore(screenshots): Updated screenshots * rebase and update * Revert "chore(deps): update dependency ts-patch to v3 (patternfly#9271)" (patternfly#9701) This reverts commit 03985a2. * chore(release): releasing packages [ci skip] - @patternfly/[email protected] * fix: white space change to trigger new prereleases [skip-a11y] * fix: whitespace changes to trigger prereleases (patternfly#9702) * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] * fix: Release alphas from v6 and rebase from main (patternfly#9692) * refactor(SliderStep): use token instead for hardcoded value (patternfly#9651) * feat(Drawer): Added start and end to position props, updated resizing to work with RTL (patternfly#9627) * feat(Drawer): Added start and end to position props, updaed resizing to work with RTL * update logic for newsize * fix(Modal): Prevent duplicate ids within Modal (patternfly#9555) * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * chore(Brand): update tests (patternfly#9543) * chore(Brand): update tests * add more tests * add width test * test updates * feat(Select) - add appendTo to SelectPopperProps (patternfly#9578) * fix(misc): fixed broken CodeSandbox demos (patternfly#9519) * update import paths * fix(table): update data imports to absolute * fix remaining codesandbox demos * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * chore: update breadcrumb dropdown item arrow to work in RTL (patternfly#9603) * chore: update breadcrumb dropdown item arrow to work in RTL * chore: use icon with shouldMirrorRTL instead * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * fix(Slider): Updated slider to work in RTL. (patternfly#9655) * fix(Slider): Updred slider to work in RTL. Deprecated rightActions and leftActions props, added endActions and startActions props. * fixes from comments * docs(Toolbar): remove test example (patternfly#9614) * docs(tabs): Clean up React documentation content. (patternfly#9606) * docs(tabs):clean up React documentation content. * Update packages/react-core/src/components/Tabs/examples/Tabs.md * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * fix(popper): add start/end positioning with RTL support, update default (patternfly#9628) * fix(popper): add start/end positioning with RTL support, update default * ensure that getLanguageDirection only returns ltr or rtl * fix(Popper): expanded types to include start/end; updated position value * fix(Dropdown): Add appendTo to dropdownPopperProps interface (patternfly#9635) * feat(Timestamp): allowed displayed datetime to be UTC (patternfly#9649) * feat(Timestamp): allowed displayed datetime to be UTC * Updated rendering of default UTC suffix * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * chore(deps): update dependency @patternfly/patternfly to v5.1.0-prerelease.32 (patternfly#9642) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(Tabs): allow RTL scrolling (patternfly#9633) * fix(Tabs): allow RTL scrolling * add direction assignment to update * update aria label descriptions * add props and deprecate old, update internal state names * update desc * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] * fix(Nav): allow RTL scrolling (patternfly#9637) * fix(Nav): allow rtl scrolling * add direction assignment to update * update aria label descriptions * add new props and deprecate old * update desc * update other test snaps * chore(BackgroundImage): update tests (patternfly#9584) * chore(BackgroundImage): update tests * add spread prop test, update test * use styles obj * update test name to use styles * feat(Label) add option to make label clickable (patternfly#9284) * feat(Label) add option to make label clickable * add type to label button * chore(Label): Address misc PR feedback * chore(Label): Remove mention of onClick being incompatible with overflow * chore(Label): Remove prop from effect deps where it's no longer needed --------- Co-authored-by: Austin Sullivan <[email protected]> * feat(charts): add RTL legend support (patternfly#9570) * feat(charts): add RTL legend support * clone data/label components * remove legend positions, add beta * remove last position update * update logic to account for text length * update clones * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * fix(PrimaryDetail): remove primary detail card view require statement (patternfly#9661) * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * fix(Draggable): dont disable droppable on false ondrag (patternfly#9646) * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * chore(screenshots): Updated screenshots (patternfly#9660) * chore(screenshots): Updated screenshots * rebase and update * fix: dry run publishing v6 alphas --------- Co-authored-by: adamviktora <[email protected]> Co-authored-by: Titani Labaj <[email protected]> Co-authored-by: Austin Sullivan <[email protected]> Co-authored-by: patternfly-build <[email protected]> Co-authored-by: kmcfaul <[email protected]> Co-authored-by: Maria <[email protected]> Co-authored-by: Jenny <[email protected]> Co-authored-by: Michael Coker <[email protected]> Co-authored-by: Erin Donehoo <[email protected]> Co-authored-by: Eric Olkowski <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Dominik Petřík <[email protected]> Co-authored-by: Dallas <[email protected]> * fix: whitespace change to try out dryrun * fix: remove --no-private with dryrun [skip-a11y] * fix: turn off dry run and release alphas [skip-a11y] * chore(release): releasing packages [ci skip] - [email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] --------- Co-authored-by: adamviktora <[email protected]> Co-authored-by: Austin Sullivan <[email protected]> Co-authored-by: patternfly-build <[email protected]> Co-authored-by: kmcfaul <[email protected]> Co-authored-by: Maria <[email protected]> Co-authored-by: Jenny <[email protected]> Co-authored-by: Michael Coker <[email protected]> Co-authored-by: Erin Donehoo <[email protected]> Co-authored-by: Eric Olkowski <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Dominik Petřík <[email protected]> Co-authored-by: Dallas <[email protected]> Co-authored-by: Nicole Thoen <[email protected]>

* refactor(SliderStep): use token instead for hardcoded value (patternfly#9651) * feat(Drawer): Added start and end to position props, updated resizing to work with RTL (patternfly#9627) * feat(Drawer): Added start and end to position props, updaed resizing to work with RTL * update logic for newsize * fix(Modal): Prevent duplicate ids within Modal (patternfly#9555) * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * chore(Brand): update tests (patternfly#9543) * chore(Brand): update tests * add more tests * add width test * test updates * feat(Select) - add appendTo to SelectPopperProps (patternfly#9578) * fix(misc): fixed broken CodeSandbox demos (patternfly#9519) * update import paths * fix(table): update data imports to absolute * fix remaining codesandbox demos * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * chore: update breadcrumb dropdown item arrow to work in RTL (patternfly#9603) * chore: update breadcrumb dropdown item arrow to work in RTL * chore: use icon with shouldMirrorRTL instead * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * fix(Slider): Updated slider to work in RTL. (patternfly#9655) * fix(Slider): Updred slider to work in RTL. Deprecated rightActions and leftActions props, added endActions and startActions props. * fixes from comments * docs(Toolbar): remove test example (patternfly#9614) * docs(tabs): Clean up React documentation content. (patternfly#9606) * docs(tabs):clean up React documentation content. * Update packages/react-core/src/components/Tabs/examples/Tabs.md * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * fix(popper): add start/end positioning with RTL support, update default (patternfly#9628) * fix(popper): add start/end positioning with RTL support, update default * ensure that getLanguageDirection only returns ltr or rtl * fix(Popper): expanded types to include start/end; updated position value * fix(Dropdown): Add appendTo to dropdownPopperProps interface (patternfly#9635) * feat(Timestamp): allowed displayed datetime to be UTC (patternfly#9649) * feat(Timestamp): allowed displayed datetime to be UTC * Updated rendering of default UTC suffix * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * chore(deps): update dependency @patternfly/patternfly to v5.1.0-prerelease.32 (patternfly#9642) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(Tabs): allow RTL scrolling (patternfly#9633) * fix(Tabs): allow RTL scrolling * add direction assignment to update * update aria label descriptions * add props and deprecate old, update internal state names * update desc * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] * fix(Nav): allow RTL scrolling (patternfly#9637) * fix(Nav): allow rtl scrolling * add direction assignment to update * update aria label descriptions * add new props and deprecate old * update desc * update other test snaps * chore(BackgroundImage): update tests (patternfly#9584) * chore(BackgroundImage): update tests * add spread prop test, update test * use styles obj * update test name to use styles * feat(Label) add option to make label clickable (patternfly#9284) * feat(Label) add option to make label clickable * add type to label button * chore(Label): Address misc PR feedback * chore(Label): Remove mention of onClick being incompatible with overflow * chore(Label): Remove prop from effect deps where it's no longer needed --------- Co-authored-by: Austin Sullivan <[email protected]> * feat(charts): add RTL legend support (patternfly#9570) * feat(charts): add RTL legend support * clone data/label components * remove legend positions, add beta * remove last position update * update logic to account for text length * update clones * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * fix(PrimaryDetail): remove primary detail card view require statement (patternfly#9661) * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * fix(Draggable): dont disable droppable on false ondrag (patternfly#9646) * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * chore(screenshots): Updated screenshots (patternfly#9660) * chore(screenshots): Updated screenshots * rebase and update * fix: dry run publishing v6 alphas --------- Co-authored-by: adamviktora <[email protected]> Co-authored-by: Titani Labaj <[email protected]> Co-authored-by: Austin Sullivan <[email protected]> Co-authored-by: patternfly-build <[email protected]> Co-authored-by: kmcfaul <[email protected]> Co-authored-by: Maria <[email protected]> Co-authored-by: Jenny <[email protected]> Co-authored-by: Michael Coker <[email protected]> Co-authored-by: Erin Donehoo <[email protected]> Co-authored-by: Eric Olkowski <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Dominik Petřík <[email protected]> Co-authored-by: Dallas <[email protected]>

* refactor(SliderStep): use token instead for hardcoded value (patternfly#9651) * feat(Drawer): Added start and end to position props, updated resizing to work with RTL (patternfly#9627) * feat(Drawer): Added start and end to position props, updaed resizing to work with RTL * update logic for newsize * fix(Modal): Prevent duplicate ids within Modal (patternfly#9555) * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * chore(Brand): update tests (patternfly#9543) * chore(Brand): update tests * add more tests * add width test * test updates * feat(Select) - add appendTo to SelectPopperProps (patternfly#9578) * fix(misc): fixed broken CodeSandbox demos (patternfly#9519) * update import paths * fix(table): update data imports to absolute * fix remaining codesandbox demos * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * chore: update breadcrumb dropdown item arrow to work in RTL (patternfly#9603) * chore: update breadcrumb dropdown item arrow to work in RTL * chore: use icon with shouldMirrorRTL instead * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * fix(Slider): Updated slider to work in RTL. (patternfly#9655) * fix(Slider): Updred slider to work in RTL. Deprecated rightActions and leftActions props, added endActions and startActions props. * fixes from comments * docs(Toolbar): remove test example (patternfly#9614) * docs(tabs): Clean up React documentation content. (patternfly#9606) * docs(tabs):clean up React documentation content. * Update packages/react-core/src/components/Tabs/examples/Tabs.md * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * fix(popper): add start/end positioning with RTL support, update default (patternfly#9628) * fix(popper): add start/end positioning with RTL support, update default * ensure that getLanguageDirection only returns ltr or rtl * fix(Popper): expanded types to include start/end; updated position value * fix(Dropdown): Add appendTo to dropdownPopperProps interface (patternfly#9635) * feat(Timestamp): allowed displayed datetime to be UTC (patternfly#9649) * feat(Timestamp): allowed displayed datetime to be UTC * Updated rendering of default UTC suffix * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * chore(deps): update dependency @patternfly/patternfly to v5.1.0-prerelease.32 (patternfly#9642) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(Tabs): allow RTL scrolling (patternfly#9633) * fix(Tabs): allow RTL scrolling * add direction assignment to update * update aria label descriptions * add props and deprecate old, update internal state names * update desc * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] * fix(Nav): allow RTL scrolling (patternfly#9637) * fix(Nav): allow rtl scrolling * add direction assignment to update * update aria label descriptions * add new props and deprecate old * update desc * update other test snaps * chore(BackgroundImage): update tests (patternfly#9584) * chore(BackgroundImage): update tests * add spread prop test, update test * use styles obj * update test name to use styles * feat(Label) add option to make label clickable (patternfly#9284) * feat(Label) add option to make label clickable * add type to label button * chore(Label): Address misc PR feedback * chore(Label): Remove mention of onClick being incompatible with overflow * chore(Label): Remove prop from effect deps where it's no longer needed --------- Co-authored-by: Austin Sullivan <[email protected]> * feat(charts): add RTL legend support (patternfly#9570) * feat(charts): add RTL legend support * clone data/label components * remove legend positions, add beta * remove last position update * update logic to account for text length * update clones * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * fix(PrimaryDetail): remove primary detail card view require statement (patternfly#9661) * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * fix(Draggable): dont disable droppable on false ondrag (patternfly#9646) * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * chore(screenshots): Updated screenshots (patternfly#9660) * chore(screenshots): Updated screenshots * rebase and update * Revert "chore(deps): update dependency ts-patch to v3 (patternfly#9271)" (patternfly#9701) This reverts commit 03985a2. * chore(release): releasing packages [ci skip] - @patternfly/[email protected] * fix: white space change to trigger new prereleases [skip-a11y] * fix: whitespace changes to trigger prereleases (patternfly#9702) * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] * fix: Release alphas from v6 and rebase from main (patternfly#9692) * refactor(SliderStep): use token instead for hardcoded value (patternfly#9651) * feat(Drawer): Added start and end to position props, updated resizing to work with RTL (patternfly#9627) * feat(Drawer): Added start and end to position props, updaed resizing to work with RTL * update logic for newsize * fix(Modal): Prevent duplicate ids within Modal (patternfly#9555) * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * chore(Brand): update tests (patternfly#9543) * chore(Brand): update tests * add more tests * add width test * test updates * feat(Select) - add appendTo to SelectPopperProps (patternfly#9578) * fix(misc): fixed broken CodeSandbox demos (patternfly#9519) * update import paths * fix(table): update data imports to absolute * fix remaining codesandbox demos * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * chore: update breadcrumb dropdown item arrow to work in RTL (patternfly#9603) * chore: update breadcrumb dropdown item arrow to work in RTL * chore: use icon with shouldMirrorRTL instead * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * fix(Slider): Updated slider to work in RTL. (patternfly#9655) * fix(Slider): Updred slider to work in RTL. Deprecated rightActions and leftActions props, added endActions and startActions props. * fixes from comments * docs(Toolbar): remove test example (patternfly#9614) * docs(tabs): Clean up React documentation content. (patternfly#9606) * docs(tabs):clean up React documentation content. * Update packages/react-core/src/components/Tabs/examples/Tabs.md * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * fix(popper): add start/end positioning with RTL support, update default (patternfly#9628) * fix(popper): add start/end positioning with RTL support, update default * ensure that getLanguageDirection only returns ltr or rtl * fix(Popper): expanded types to include start/end; updated position value * fix(Dropdown): Add appendTo to dropdownPopperProps interface (patternfly#9635) * feat(Timestamp): allowed displayed datetime to be UTC (patternfly#9649) * feat(Timestamp): allowed displayed datetime to be UTC * Updated rendering of default UTC suffix * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * chore(deps): update dependency @patternfly/patternfly to v5.1.0-prerelease.32 (patternfly#9642) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(Tabs): allow RTL scrolling (patternfly#9633) * fix(Tabs): allow RTL scrolling * add direction assignment to update * update aria label descriptions * add props and deprecate old, update internal state names * update desc * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] * fix(Nav): allow RTL scrolling (patternfly#9637) * fix(Nav): allow rtl scrolling * add direction assignment to update * update aria label descriptions * add new props and deprecate old * update desc * update other test snaps * chore(BackgroundImage): update tests (patternfly#9584) * chore(BackgroundImage): update tests * add spread prop test, update test * use styles obj * update test name to use styles * feat(Label) add option to make label clickable (patternfly#9284) * feat(Label) add option to make label clickable * add type to label button * chore(Label): Address misc PR feedback * chore(Label): Remove mention of onClick being incompatible with overflow * chore(Label): Remove prop from effect deps where it's no longer needed --------- Co-authored-by: Austin Sullivan <[email protected]> * feat(charts): add RTL legend support (patternfly#9570) * feat(charts): add RTL legend support * clone data/label components * remove legend positions, add beta * remove last position update * update logic to account for text length * update clones * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * fix(PrimaryDetail): remove primary detail card view require statement (patternfly#9661) * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * fix(Draggable): dont disable droppable on false ondrag (patternfly#9646) * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * chore(screenshots): Updated screenshots (patternfly#9660) * chore(screenshots): Updated screenshots * rebase and update * fix: dry run publishing v6 alphas --------- Co-authored-by: adamviktora <[email protected]> Co-authored-by: Titani Labaj <[email protected]> Co-authored-by: Austin Sullivan <[email protected]> Co-authored-by: patternfly-build <[email protected]> Co-authored-by: kmcfaul <[email protected]> Co-authored-by: Maria <[email protected]> Co-authored-by: Jenny <[email protected]> Co-authored-by: Michael Coker <[email protected]> Co-authored-by: Erin Donehoo <[email protected]> Co-authored-by: Eric Olkowski <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Dominik Petřík <[email protected]> Co-authored-by: Dallas <[email protected]> * fix: whitespace change to try out dryrun * fix: remove --no-private with dryrun [skip-a11y] * fix: turn off dry run and release alphas [skip-a11y] * chore(release): releasing packages [ci skip] - [email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] --------- Co-authored-by: adamviktora <[email protected]> Co-authored-by: Austin Sullivan <[email protected]> Co-authored-by: patternfly-build <[email protected]> Co-authored-by: kmcfaul <[email protected]> Co-authored-by: Maria <[email protected]> Co-authored-by: Jenny <[email protected]> Co-authored-by: Michael Coker <[email protected]> Co-authored-by: Erin Donehoo <[email protected]> Co-authored-by: Eric Olkowski <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Dominik Petřík <[email protected]> Co-authored-by: Dallas <[email protected]> Co-authored-by: Nicole Thoen <[email protected]>

* refactor(SliderStep): use token instead for hardcoded value (patternfly#9651) * feat(Drawer): Added start and end to position props, updated resizing to work with RTL (patternfly#9627) * feat(Drawer): Added start and end to position props, updaed resizing to work with RTL * update logic for newsize * fix(Modal): Prevent duplicate ids within Modal (patternfly#9555) * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * chore(Brand): update tests (patternfly#9543) * chore(Brand): update tests * add more tests * add width test * test updates * feat(Select) - add appendTo to SelectPopperProps (patternfly#9578) * fix(misc): fixed broken CodeSandbox demos (patternfly#9519) * update import paths * fix(table): update data imports to absolute * fix remaining codesandbox demos * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * chore: update breadcrumb dropdown item arrow to work in RTL (patternfly#9603) * chore: update breadcrumb dropdown item arrow to work in RTL * chore: use icon with shouldMirrorRTL instead * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * fix(Slider): Updated slider to work in RTL. (patternfly#9655) * fix(Slider): Updred slider to work in RTL. Deprecated rightActions and leftActions props, added endActions and startActions props. * fixes from comments * docs(Toolbar): remove test example (patternfly#9614) * docs(tabs): Clean up React documentation content. (patternfly#9606) * docs(tabs):clean up React documentation content. * Update packages/react-core/src/components/Tabs/examples/Tabs.md * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * fix(popper): add start/end positioning with RTL support, update default (patternfly#9628) * fix(popper): add start/end positioning with RTL support, update default * ensure that getLanguageDirection only returns ltr or rtl * fix(Popper): expanded types to include start/end; updated position value * fix(Dropdown): Add appendTo to dropdownPopperProps interface (patternfly#9635) * feat(Timestamp): allowed displayed datetime to be UTC (patternfly#9649) * feat(Timestamp): allowed displayed datetime to be UTC * Updated rendering of default UTC suffix * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * chore(deps): update dependency @patternfly/patternfly to v5.1.0-prerelease.32 (patternfly#9642) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(Tabs): allow RTL scrolling (patternfly#9633) * fix(Tabs): allow RTL scrolling * add direction assignment to update * update aria label descriptions * add props and deprecate old, update internal state names * update desc * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] * fix(Nav): allow RTL scrolling (patternfly#9637) * fix(Nav): allow rtl scrolling * add direction assignment to update * update aria label descriptions * add new props and deprecate old * update desc * update other test snaps * chore(BackgroundImage): update tests (patternfly#9584) * chore(BackgroundImage): update tests * add spread prop test, update test * use styles obj * update test name to use styles * feat(Label) add option to make label clickable (patternfly#9284) * feat(Label) add option to make label clickable * add type to label button * chore(Label): Address misc PR feedback * chore(Label): Remove mention of onClick being incompatible with overflow * chore(Label): Remove prop from effect deps where it's no longer needed --------- Co-authored-by: Austin Sullivan <[email protected]> * feat(charts): add RTL legend support (patternfly#9570) * feat(charts): add RTL legend support * clone data/label components * remove legend positions, add beta * remove last position update * update logic to account for text length * update clones * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * fix(PrimaryDetail): remove primary detail card view require statement (patternfly#9661) * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * fix(Draggable): dont disable droppable on false ondrag (patternfly#9646) * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * chore(screenshots): Updated screenshots (patternfly#9660) * chore(screenshots): Updated screenshots * rebase and update * fix: dry run publishing v6 alphas --------- Co-authored-by: adamviktora <[email protected]> Co-authored-by: Titani Labaj <[email protected]> Co-authored-by: Austin Sullivan <[email protected]> Co-authored-by: patternfly-build <[email protected]> Co-authored-by: kmcfaul <[email protected]> Co-authored-by: Maria <[email protected]> Co-authored-by: Jenny <[email protected]> Co-authored-by: Michael Coker <[email protected]> Co-authored-by: Erin Donehoo <[email protected]> Co-authored-by: Eric Olkowski <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Dominik Petřík <[email protected]> Co-authored-by: Dallas <[email protected]>

* refactor(SliderStep): use token instead for hardcoded value (patternfly#9651) * feat(Drawer): Added start and end to position props, updated resizing to work with RTL (patternfly#9627) * feat(Drawer): Added start and end to position props, updaed resizing to work with RTL * update logic for newsize * fix(Modal): Prevent duplicate ids within Modal (patternfly#9555) * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * chore(Brand): update tests (patternfly#9543) * chore(Brand): update tests * add more tests * add width test * test updates * feat(Select) - add appendTo to SelectPopperProps (patternfly#9578) * fix(misc): fixed broken CodeSandbox demos (patternfly#9519) * update import paths * fix(table): update data imports to absolute * fix remaining codesandbox demos * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * chore: update breadcrumb dropdown item arrow to work in RTL (patternfly#9603) * chore: update breadcrumb dropdown item arrow to work in RTL * chore: use icon with shouldMirrorRTL instead * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * fix(Slider): Updated slider to work in RTL. (patternfly#9655) * fix(Slider): Updred slider to work in RTL. Deprecated rightActions and leftActions props, added endActions and startActions props. * fixes from comments * docs(Toolbar): remove test example (patternfly#9614) * docs(tabs): Clean up React documentation content. (patternfly#9606) * docs(tabs):clean up React documentation content. * Update packages/react-core/src/components/Tabs/examples/Tabs.md * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * fix(popper): add start/end positioning with RTL support, update default (patternfly#9628) * fix(popper): add start/end positioning with RTL support, update default * ensure that getLanguageDirection only returns ltr or rtl * fix(Popper): expanded types to include start/end; updated position value * fix(Dropdown): Add appendTo to dropdownPopperProps interface (patternfly#9635) * feat(Timestamp): allowed displayed datetime to be UTC (patternfly#9649) * feat(Timestamp): allowed displayed datetime to be UTC * Updated rendering of default UTC suffix * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * chore(deps): update dependency @patternfly/patternfly to v5.1.0-prerelease.32 (patternfly#9642) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(Tabs): allow RTL scrolling (patternfly#9633) * fix(Tabs): allow RTL scrolling * add direction assignment to update * update aria label descriptions * add props and deprecate old, update internal state names * update desc * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] * fix(Nav): allow RTL scrolling (patternfly#9637) * fix(Nav): allow rtl scrolling * add direction assignment to update * update aria label descriptions * add new props and deprecate old * update desc * update other test snaps * chore(BackgroundImage): update tests (patternfly#9584) * chore(BackgroundImage): update tests * add spread prop test, update test * use styles obj * update test name to use styles * feat(Label) add option to make label clickable (patternfly#9284) * feat(Label) add option to make label clickable * add type to label button * chore(Label): Address misc PR feedback * chore(Label): Remove mention of onClick being incompatible with overflow * chore(Label): Remove prop from effect deps where it's no longer needed --------- Co-authored-by: Austin Sullivan <[email protected]> * feat(charts): add RTL legend support (patternfly#9570) * feat(charts): add RTL legend support * clone data/label components * remove legend positions, add beta * remove last position update * update logic to account for text length * update clones * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * fix(PrimaryDetail): remove primary detail card view require statement (patternfly#9661) * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * fix(Draggable): dont disable droppable on false ondrag (patternfly#9646) * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * chore(screenshots): Updated screenshots (patternfly#9660) * chore(screenshots): Updated screenshots * rebase and update * Revert "chore(deps): update dependency ts-patch to v3 (patternfly#9271)" (patternfly#9701) This reverts commit 03985a2. * chore(release): releasing packages [ci skip] - @patternfly/[email protected] * fix: white space change to trigger new prereleases [skip-a11y] * fix: whitespace changes to trigger prereleases (patternfly#9702) * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] * fix: Release alphas from v6 and rebase from main (patternfly#9692) * refactor(SliderStep): use token instead for hardcoded value (patternfly#9651) * feat(Drawer): Added start and end to position props, updated resizing to work with RTL (patternfly#9627) * feat(Drawer): Added start and end to position props, updaed resizing to work with RTL * update logic for newsize * fix(Modal): Prevent duplicate ids within Modal (patternfly#9555) * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * chore(Brand): update tests (patternfly#9543) * chore(Brand): update tests * add more tests * add width test * test updates * feat(Select) - add appendTo to SelectPopperProps (patternfly#9578) * fix(misc): fixed broken CodeSandbox demos (patternfly#9519) * update import paths * fix(table): update data imports to absolute * fix remaining codesandbox demos * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * chore: update breadcrumb dropdown item arrow to work in RTL (patternfly#9603) * chore: update breadcrumb dropdown item arrow to work in RTL * chore: use icon with shouldMirrorRTL instead * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * fix(Slider): Updated slider to work in RTL. (patternfly#9655) * fix(Slider): Updred slider to work in RTL. Deprecated rightActions and leftActions props, added endActions and startActions props. * fixes from comments * docs(Toolbar): remove test example (patternfly#9614) * docs(tabs): Clean up React documentation content. (patternfly#9606) * docs(tabs):clean up React documentation content. * Update packages/react-core/src/components/Tabs/examples/Tabs.md * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * fix(popper): add start/end positioning with RTL support, update default (patternfly#9628) * fix(popper): add start/end positioning with RTL support, update default * ensure that getLanguageDirection only returns ltr or rtl * fix(Popper): expanded types to include start/end; updated position value * fix(Dropdown): Add appendTo to dropdownPopperProps interface (patternfly#9635) * feat(Timestamp): allowed displayed datetime to be UTC (patternfly#9649) * feat(Timestamp): allowed displayed datetime to be UTC * Updated rendering of default UTC suffix * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * chore(deps): update dependency @patternfly/patternfly to v5.1.0-prerelease.32 (patternfly#9642) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(Tabs): allow RTL scrolling (patternfly#9633) * fix(Tabs): allow RTL scrolling * add direction assignment to update * update aria label descriptions * add props and deprecate old, update internal state names * update desc * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] * fix(Nav): allow RTL scrolling (patternfly#9637) * fix(Nav): allow rtl scrolling * add direction assignment to update * update aria label descriptions * add new props and deprecate old * update desc * update other test snaps * chore(BackgroundImage): update tests (patternfly#9584) * chore(BackgroundImage): update tests * add spread prop test, update test * use styles obj * update test name to use styles * feat(Label) add option to make label clickable (patternfly#9284) * feat(Label) add option to make label clickable * add type to label button * chore(Label): Address misc PR feedback * chore(Label): Remove mention of onClick being incompatible with overflow * chore(Label): Remove prop from effect deps where it's no longer needed --------- Co-authored-by: Austin Sullivan <[email protected]> * feat(charts): add RTL legend support (patternfly#9570) * feat(charts): add RTL legend support * clone data/label components * remove legend positions, add beta * remove last position update * update logic to account for text length * update clones * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * fix(PrimaryDetail): remove primary detail card view require statement (patternfly#9661) * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * fix(Draggable): dont disable droppable on false ondrag (patternfly#9646) * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * chore(screenshots): Updated screenshots (patternfly#9660) * chore(screenshots): Updated screenshots * rebase and update * fix: dry run publishing v6 alphas --------- Co-authored-by: adamviktora <[email protected]> Co-authored-by: Titani Labaj <[email protected]> Co-authored-by: Austin Sullivan <[email protected]> Co-authored-by: patternfly-build <[email protected]> Co-authored-by: kmcfaul <[email protected]> Co-authored-by: Maria <[email protected]> Co-authored-by: Jenny <[email protected]> Co-authored-by: Michael Coker <[email protected]> Co-authored-by: Erin Donehoo <[email protected]> Co-authored-by: Eric Olkowski <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Dominik Petřík <[email protected]> Co-authored-by: Dallas <[email protected]> * fix: whitespace change to try out dryrun * fix: remove --no-private with dryrun [skip-a11y] * fix: turn off dry run and release alphas [skip-a11y] * chore(release): releasing packages [ci skip] - [email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] --------- Co-authored-by: adamviktora <[email protected]> Co-authored-by: Austin Sullivan <[email protected]> Co-authored-by: patternfly-build <[email protected]> Co-authored-by: kmcfaul <[email protected]> Co-authored-by: Maria <[email protected]> Co-authored-by: Jenny <[email protected]> Co-authored-by: Michael Coker <[email protected]> Co-authored-by: Erin Donehoo <[email protected]> Co-authored-by: Eric Olkowski <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Dominik Petřík <[email protected]> Co-authored-by: Dallas <[email protected]> Co-authored-by: Nicole Thoen <[email protected]>

mcoker requested review from kmcfaul, thatblindgeye, tlabaj and wise-king-sullyman September 12, 2023 03:11

thatblindgeye reviewed Sep 12, 2023

View reviewed changes

thatblindgeye mentioned this pull request Sep 12, 2023

fix(menu): updated drilldown breadcrumb menu icons to work in RTL patternfly/patternfly#5924

Merged

srambach mentioned this pull request Sep 12, 2023

RTL - Core followup for RTL changes #9521

Closed

83 tasks

mcoker added 2 commits September 19, 2023 13:14

chore: update breadcrumb dropdown item arrow to work in RTL

5e3a16c

chore: use icon with shouldMirrorRTL instead

53bcbdb

mcoker force-pushed the issue-9587 branch from 55731b8 to 53bcbdb Compare September 19, 2023 18:37

mcoker requested a review from thatblindgeye September 19, 2023 18:38

thatblindgeye approved these changes Sep 19, 2023

View reviewed changes

wise-king-sullyman approved these changes Sep 19, 2023

View reviewed changes

tlabaj reviewed Sep 20, 2023

View reviewed changes

tlabaj approved these changes Sep 21, 2023

View reviewed changes

tlabaj merged commit 82fbf44 into patternfly:main Sep 21, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: update breadcrumb dropdown item arrow to work in RTL#9603

chore: update breadcrumb dropdown item arrow to work in RTL#9603
tlabaj merged 2 commits intopatternfly:mainfrom
mcoker:issue-9587

mcoker commented Sep 12, 2023

Uh oh!

patternfly-build commented Sep 12, 2023 •

edited

Loading

Uh oh!

thatblindgeye left a comment •

edited

Loading

Uh oh!

thatblindgeye commented Sep 18, 2023

Uh oh!

mcoker commented Sep 18, 2023

Uh oh!

thatblindgeye commented Sep 19, 2023

Uh oh!

wise-king-sullyman commented Sep 19, 2023

Uh oh!

tlabaj left a comment

Uh oh!

mcoker commented Sep 20, 2023

Uh oh!

patternfly-build commented Sep 21, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

	let drill: (event: React.KeyboardEvent \| React.MouseEvent) => void;
	if (direction) {
	if (direction === 'down') {
	drill = (event) =>
	onDrillIn &&
	onDrillIn(
	event,
	menuId,
	typeof drilldownMenu === 'function'
	? (drilldownMenu() as any).props.id
	: (drilldownMenu as React.ReactElement).props.id,
	itemId
	);
	} else {
	drill = (event) => onDrillOut && onDrillOut(event, parentMenu, itemId);
	}
	}

Conversation

mcoker commented Sep 12, 2023

Uh oh!

patternfly-build commented Sep 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

thatblindgeye left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

thatblindgeye commented Sep 18, 2023

Uh oh!

mcoker commented Sep 18, 2023

Uh oh!

thatblindgeye commented Sep 19, 2023

Uh oh!

wise-king-sullyman commented Sep 19, 2023

Uh oh!

tlabaj left a comment

Choose a reason for hiding this comment

Uh oh!

mcoker commented Sep 20, 2023

Uh oh!

patternfly-build commented Sep 21, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

patternfly-build commented Sep 12, 2023 •

edited

Loading

thatblindgeye left a comment •

edited

Loading