feat(Icon): added prop for mirroring in RTL#9609
Merged
tlabaj merged 1 commit intopatternfly:mainfrom Sep 13, 2023
Merged
Conversation
Collaborator
|
Preview: https://patternfly-react-pr-9609.surge.sh A11y report: https://patternfly-react-pr-9609-a11y.surge.sh |
wise-king-sullyman
approved these changes
Sep 12, 2023
Collaborator
wise-king-sullyman
left a comment
There was a problem hiding this comment.
Not blocking, but I wonder if we should default to having this true since I feel like in most scenarios not mirroring is more likely to be detrimental to UX than mirroring is.
Contributor
|
@wise-king-sullyman Since we have no restrictions on what goes in as an icon, it feels a bit too opinionated to mirror in RTL? We could see how that ends up playing out, too, and update if we get feedback about it. |
tlabaj
approved these changes
Sep 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Closes #9595
Additional issues: