-
Notifications
You must be signed in to change notification settings - Fork 377
chore(ExpandableSection): updated indented example for Penta disclosure variation #9894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Preview: https://patternfly-react-pr-9894.surge.sh A11y report: https://patternfly-react-pr-9894-a11y.surge.sh |
|
The surge on this seems to be broken. |
|
@andrew-ronaldson That might be worth a convo, as the Accordion component behaves the same way. If we don't want that styling on click we should be able to update styles in Core to |
|
It took me a while to figure out the difference between the large indent example, and the disclosure variation. Could we add a sentence or be a little clearer in the example title what the purpose of the disclosure variation is? And maybe update the indent example to be called 'indent expandable content body' or something like that, to make it clearer? |
02c4fcc to
54475d8
Compare
|
it looks like according to the core docs that the disclosure variant is the large display size variant? could that be true? |
|
it feels like the checkbox label for the indented version should read "disclosure variant"? otherwise looks good to me! |
54475d8 to
6cd335a
Compare
andrew-ronaldson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved!
mcoker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
|
Your changes have been released in:
Thanks for your contribution! 🎉 |

What: Closes #9850
No other updates needed to consume Penta tokens
Additional issues: