Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@thatblindgeye
Copy link
Contributor

@thatblindgeye thatblindgeye commented Dec 14, 2023

What: Closes #9850

No other updates needed to consume Penta tokens

Additional issues:

@thatblindgeye thatblindgeye requested review from a team, andrew-ronaldson, kmcfaul, lboehling, mattnolting and nicolethoen and removed request for a team December 14, 2023 13:35
@patternfly-build
Copy link
Collaborator

patternfly-build commented Dec 14, 2023

@andrew-ronaldson
Copy link
Collaborator

The surge on this seems to be broken.

@andrew-ronaldson
Copy link
Collaborator

On the disclosure variation the hover state seems to stay until I click out of the example area. Do we have an Clicked/active state. May just be a weird site thing.
Screenshot 2023-12-19 at 11 33 28 AM

@thatblindgeye
Copy link
Contributor Author

@andrew-ronaldson That might be worth a convo, as the Accordion component behaves the same way. If we don't want that styling on click we should be able to update styles in Core to focus-visible instead of just focus, similar to the update made to Switch

@nicolethoen
Copy link
Contributor

It took me a while to figure out the difference between the large indent example, and the disclosure variation.

Could we add a sentence or be a little clearer in the example title what the purpose of the disclosure variation is? And maybe update the indent example to be called 'indent expandable content body' or something like that, to make it clearer?

@nicolethoen
Copy link
Contributor

it looks like according to the core docs that the disclosure variant is the large display size variant? could that be true?

@thatblindgeye thatblindgeye linked an issue Jan 5, 2024 that may be closed by this pull request
@lboehling
Copy link
Collaborator

it feels like the checkbox label for the indented version should read "disclosure variant"? otherwise looks good to me!

@thatblindgeye thatblindgeye force-pushed the expandableSectionPenta branch from 54475d8 to 6cd335a Compare January 12, 2024 16:04
Copy link
Collaborator

@andrew-ronaldson andrew-ronaldson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

Copy link
Contributor

@mcoker mcoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@tlabaj tlabaj merged commit 88d81fe into patternfly:v6 Jan 17, 2024
@patternfly-build
Copy link
Collaborator

Your changes have been released in:

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expandable Section: Consume Penta tokens

9 participants