Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat(Pagination): applied Penta updates #9971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wise-king-sullyman merged 4 commits into from
Jan 18, 2024
Merged

feat(Pagination): applied Penta updates #9971

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7d2f9de
feat(Pagination): applied Penta updates
Jan 15, 2024
8564dd0
Added back usePageInsets prop
Jan 16, 2024
e8d2b16
Updated snapshots
Jan 16, 2024
4e217d5
Added test file for PaginationOptionsMenu
Jan 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/react-core/src/components/Pagination/PaginationOptionsMenu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import * as React from 'react';
import styles from '@patternfly/react-styles/css/components/Pagination/pagination';
import { css } from '@patternfly/react-styles';
import { Menu, MenuContent, MenuList, MenuItem } from '../Menu';
import { MenuToggle } from '../MenuToggle';
Expand Down Expand Up @@ -210,7 +211,7 @@ export const PaginationOptionsMenu: React.FunctionComponent<PaginationOptionsMen
);

return (
<div ref={containerRef}>
<div className={css(styles.paginationPageMenu)} ref={containerRef}>
<Popper
trigger={toggle}
triggerRef={toggleRef}
Expand Down
4 changes: 3 additions & 1 deletion ...mponents/Pagination/__tests__/Generated/__snapshots__/PaginationOptionsMenu.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,9 @@

exports[`PaginationOptionsMenu should match snapshot (auto-generated) 1`] = `
<DocumentFragment>
<div>
<div
class="pf-v5-c-pagination__page-menu"
>
<button
aria-expanded="false"
aria-haspopup="listbox"
Expand Down
5 changes: 0 additions & 5 deletions packages/react-core/src/components/Pagination/__tests__/Pagination.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,11 +119,6 @@ describe('Pagination', () => {
render(<Pagination data-testid="pagination-insets" usePageInsets />);
expect(screen.getByTestId('pagination-insets')).toHaveClass('pf-m-page-insets');
});

test('page insets', () => {
render(<Pagination data-testid="pagination-insets" usePageInsets />);
expect(screen.getByTestId('pagination-insets')).toHaveClass('pf-m-page-insets');
});
});

describe('API', () => {
Expand Down
23 changes: 23 additions & 0 deletions packages/react-core/src/components/Pagination/__tests__/PaginationOptionsMenu.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
import React from 'react';
import { PaginationOptionsMenu } from '../PaginationOptionsMenu';
import { render, screen } from '@testing-library/react';
import styles from '@patternfly/react-styles/css/components/Pagination/pagination';

jest.mock('../../../helpers/Popper/Popper');

test('renders pagination options menu', () => {
render(
<div data-testid="options-menu">
<PaginationOptionsMenu toggleTemplate="Test" />
</div>
);

expect(screen.getByTestId('options-menu').children[0]).toBeVisible();
});

test(`renders with class ${styles.paginationPageMenu} by default`, () => {
render(<PaginationOptionsMenu toggleTemplate="Test" />);

// Mocked Popper is rendered with data-testid="mock-wrapper"
expect(screen.getByTestId('mock-wrapper').parentElement).toHaveClass(styles.paginationPageMenu);
});
Loading