fix: prevent resizing of original file with withoutEnlargement on update
#12291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l-file-resize-without-enlargement-update
…l-file-resize-without-enlargement-update
|
please approve. 😆 |
|
@PatrikKozak I tried your PR by modifying the build-generated While the dimensions do not change anymore, it still tries to compress the image on update. See video: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates
generateFileDatato skip applyingresizeOptionsafter updating an image ifresizeOptions.withoutEnlargementistrueand the original image size is smaller than the dimensions defined inresizeOptions.This prevents unintended re-resizing of already resized images when updating or modifying metadata without uploading a new file.
This change ensures that:
Resizing is skipped if withoutEnlargement: true
Resizing still occurs if withoutEnlargement: false or unset
This resolves an issue where images were being resized again unnecessarily when updating an upload.
Fixes #12280