fix(db-postgres): v2-v3 migration errors with relation already exists #12310
+85
−30
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes three issues identified in the predefined migration for postgres v2-v3
relation already exists
Can error with the following:
This was happening when you run a migration with both a required relationship or upload field and no schema specified in the db adapter. When both of these are true the function that replaces
ADD COLUMN
andALTER COLUMN
in order to addNOT NULL
constraints for requried fields, wasn't working. This resulted in theADD COLUMN
statement from being being called multiple times instead of altering it after data had been copied over.camelCase column change
Enum columns from using
select
orradio
have changed from camelCase to snake case in v3. This change was not accounted for in the relationship migration and needed to be accounted for.DROP CONSTRAINT
It was pointed out by here that the
DROP CONSTRAINT
needs to includeIF EXISTS
so that it can continue if the contraint was already removed in a previous statement.fixes #10162