Lambda expression for Java 8 SAM types #660
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jiminhsieh
commented
May 20, 2018
- Use Lambda expression instead of anonymous classes
- Use parallel compiler backend
- Title includes issue id.
- Description of the change added.
- Commits are squashed.
- Tests added.
- Documentation added/updated.
- Also please review CONTRIBUTING.md.
e6d1233 to
dd0b849
Compare
akara
reviewed
May 22, 2018
| Resume | ||
| } | ||
| } | ||
| (t: Throwable) => { |
There was a problem hiding this comment.
Just a style issue, I don't think you really need the parentheses or the curly braces in this line. The following should work. Please try...
t: Throwable =>
log.error(...)
...There was a problem hiding this comment.
If you need to put the whole thing in curly braces, I'd do it at the def level:
def decider: akka.japi.function.Function[Throwable, Directive] = {
t: Throwable =>
...
Resume
}| private[this] val connectionStateListener: ConnectionStateListener = new ConnectionStateListener { | ||
| override def stateChanged(client: CuratorFramework, newState: ConnectionState): Unit = { | ||
| private[this] val connectionStateListener: ConnectionStateListener = | ||
| (client: CuratorFramework, newState: ConnectionState) => { |
There was a problem hiding this comment.
Ditto, the { at the end of this line should not be needed.
| lazy val segmentWatcher: CuratorWatcher = new CuratorWatcher { | ||
| override def process(event: WatchedEvent): Unit = { | ||
| lazy val segmentWatcher: CuratorWatcher = | ||
| (event: WatchedEvent) => { |
| lazy val partitionWatcher: CuratorWatcher = new CuratorWatcher { | ||
| override def process(event: WatchedEvent): Unit = { | ||
| lazy val partitionWatcher: CuratorWatcher = | ||
| (event: WatchedEvent) => { |
There was a problem hiding this comment.
And just one more of the same.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.