Pass proper old rlocator to smgr when creating relations and indexes #156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change, the smgr would decrypt indexes and relations when moving data to new files (VACUUM FULL, REINDEX CONCURRENTLY etc) Fixes PG-1494, PG-1495, PG-1496
83afa8a to
33ee5ef
Compare
dutow
approved these changes
Mar 21, 2025
| @@ -1283,6 +1303,12 @@ heap_create_with_catalog(const char *relname, | |||
| else | |||
| relacl = NULL; | |||
|
|
|||
| if (relrewrite != InvalidOid) | |||
| { | |||
| old_rel = table_open(relrewrite, AccessShareLock); | |||
There was a problem hiding this comment.
can't we close the table immediately here?
There was a problem hiding this comment.
old_rel is a poiter to the shared buffer. We could do memcpy here but I think it is safer just to hold the lock while we are "referring" to the rel. The parallel process might for example delete this relation and then we may get in to trouble in smgrcteate
| * table_relation_set_new_filelocator() takes old_rlocator from | ||
| * rel->rd_locator | ||
| */ | ||
| rel->rd_locator = prev_rlocator; |
There was a problem hiding this comment.
Maybe it would be better to do this similarly to the OldOid in the heap create function, but this is a good workaround for now so that we can get the release progressing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, the smgr would decrypt indexes and relations when moving data to new files (VACUUM FULL, REINDEX CONCURRENTLY etc)
Fixes PG-1494, PG-1495, PG-1496