Create replication.md quick walkthrough for pg_tde #319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
started to populate replication with information and added to ToC
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-17.5.2 #319 +/- ##
=================================================
Coverage ? 84.68%
=================================================
Files ? 21
Lines ? 2593
Branches ? 401
=================================================
Hits ? 2196
Misses ? 316
Partials ? 81
🚀 New features to boost your workflow:
|
Updated text a bit, need to further lint it more PG-802 linked
Replaced master with principal
…na/postgres into DOCS-create-replication.md
dutow
requested changes
May 23, 2025
Initial commit was messy, reworded for basic users and cleared up any confusing parts like heap_tde which was incorrect
Updated the following: - Reworded the second paragraph and removed the install.md reference. I also added (which includes...) to ensure that experienced users don't just ignore the setup link and have a proper quick view of the prerequisites as well as helping new users to reinforce what they need to have configured already. - Removed CREATE EXTENSION from step 1 Configure the Primary, it is redundant. I also updated the principal key function step with a fixed link - Updated primary replication role paragraph - Removed initial standby setup as we already cover this - Updated step 3 Start and Validate replication with an intro text and added a tip to remind the user they can verify if the encrypt is
dutow
reviewed
Jun 25, 2025
- updated intro to remove () and replace with , , for tde heap access method mention - removed assumption steps when talking about pg_tde setup - added Configure postgresql.conf step for configuring the standby after db backup - updated step 3 with clear assumption that primary and standby run separately and added a warning regarding Key Management consistency between replica and primary - updated tip to include a way to copy the command with one click and added that after creating an encrypted table you can use it
dutow
approved these changes
Jun 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
started to populate replication with information and added to ToC