Fix broken code coverage job #380
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An extra space had snuck into the script.
it is unclear why it seemed to work but when adding "set -e" we got an error from the script.
fd72d08 to
3ed4bd9
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❌ Your project status has failed because the head coverage (85.42%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## TDE_REL_17_STABLE #380 +/- ##
=====================================================
+ Coverage 84.91% 85.42% +0.51%
=====================================================
Files 22 22
Lines 2611 2608 -3
Branches 397 396 -1
=====================================================
+ Hits 2217 2228 +11
+ Misses 314 305 -9
+ Partials 80 75 -5
🚀 New features to boost your workflow:
|
dAdAbird
approved these changes
May 30, 2025
|
Looks like sanitizers is the new code coverage - randomly fails on the CI |
The upstream code has been incorrectly indented since PostgreSQL 17.4 but the lack of set -e in the script hid that from us.
It recently hid a bug in the code coverage job.
3ed4bd9 to
f6f2c98
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the sanitizers broke it but since we did not use
set -eit was not noticed by our CI.