Remove undocumented shorthand for when setting keys #383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❌ Your project status has failed because the head coverage (85.47%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## TDE_REL_17_STABLE #383 +/- ##
=====================================================
+ Coverage 84.91% 85.47% +0.56%
=====================================================
Files 22 22
Lines 2611 2602 -9
Branches 397 393 -4
=====================================================
+ Hits 2217 2224 +7
+ Misses 314 303 -11
+ Partials 80 75 -5
🚀 New features to boost your workflow:
|
If we passed NULL as the pkey provider name we used to pick the current key provider which was an undcoumented feature which made the code and API harder to understand. Let's jsut remove it and see if people complain.
acaa377 to
b364c54
Compare
dutow
approved these changes
May 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we passed NULL as the pkey provider name we used to pick the current key provider which was an undcoumented feature which made the code and API harder to understand. Let's jsut remove it and see if people complain.