Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Remove ifdef within the same ifdef #387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 3, 2025

Conversation

jeltz
Copy link
Collaborator

@jeltz jeltz commented Jun 3, 2025

Since the whole function is within the same ifdef this ifdef is pointless.

Since the whole function is within the same ifdef this ifdef is
pointless.
@jeltz jeltz requested review from dutow and dAdAbird as code owners June 3, 2025 11:52
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.39%. Comparing base (ad8a0f0) to head (d2a0bf0).

❌ Your project status has failed because the head coverage (85.39%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@                Coverage Diff                 @@
##           TDE_REL_17_STABLE     #387   +/-   ##
==================================================
  Coverage              85.39%   85.39%           
==================================================
  Files                     22       22           
  Lines                   2602     2602           
  Branches                 393      393           
==================================================
  Hits                    2222     2222           
  Misses                   304      304           
  Partials                  76       76           
Components Coverage Δ
access 84.20% <ø> (ø)
catalog 88.20% <ø> (ø)
common 91.80% <ø> (ø)
encryption 73.45% <ø> (ø)
keyring 72.00% <ø> (ø)
src 91.40% <ø> (ø)
smgr 97.41% <ø> (ø)
transam ∅ <ø> (∅)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@AndersAstrand AndersAstrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙄

@jeltz jeltz merged commit 591d604 into percona:TDE_REL_17_STABLE Jun 3, 2025
16 checks passed
@jeltz jeltz deleted the tde/rm-ifdef branch June 4, 2025 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants