PG-1607 Make Vault CA path optional and clean up HTTPS code in general for Vault #392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Andriciuc
approved these changes
Jun 4, 2025
dAdAbird
approved these changes
Jun 4, 2025
a950d68 to
cba6c9e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❌ Your project status has failed because the head coverage (85.28%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## TDE_REL_17_STABLE #392 +/- ##
=====================================================
+ Coverage 85.20% 85.28% +0.07%
=====================================================
Files 22 22
Lines 2534 2534
Branches 384 385 +1
=====================================================
+ Hits 2159 2161 +2
+ Misses 301 299 -2
Partials 74 74
🚀 New features to boost your workflow:
|
5a296dc to
2f2422a
Compare
Instead of forcing people put NULL in the field when using HTTP we allow them to leave out the function argument.
…e_key_provider Also do not rely on the Vault server setup since any file on disk will do.
This is a very basic test but before this there were no tests at all.
Since the dev mode of Vault supports generating HTTPs ceritficates we should just use that since in production everyone will use HTTPS we should run our tests with HTTPS too.
We should encourage HTTPS over HTTP in out examples.
2f2422a to
bc15fd3
Compare
|
Closing this PR, at least for now, due to discussions about alternative solutions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of inputting
NULLinto thevault_ca_pathargument we allow users to just leave it out. But additionally we fix our tests to always use HTTPS and update the documentation examples to prefer HTTPS over HTTP: