Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Remove useless comments in extension SQL file #398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 6, 2025

Conversation

jeltz
Copy link
Collaborator

@jeltz jeltz commented Jun 6, 2025

These comments are repeated many times but add little to no value in practice since any such issues should be releaved by making sure we test all these functions.

@jeltz jeltz requested review from dutow and dAdAbird as code owners June 6, 2025 12:51
These comments are repeated many times but add little to no value in
practice since any such issues should be releaved by making sure we test
all these functions.
@jeltz jeltz force-pushed the tde/rm-usless-comments branch from d80763f to ca07bbf Compare June 6, 2025 12:52
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.48%. Comparing base (4575c03) to head (ca07bbf).

❌ Your project status has failed because the head coverage (85.48%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@                Coverage Diff                 @@
##           TDE_REL_17_STABLE     #398   +/-   ##
==================================================
  Coverage              85.48%   85.48%           
==================================================
  Files                     22       22           
  Lines                   2536     2536           
  Branches                 387      387           
==================================================
  Hits                    2168     2168           
  Misses                   294      294           
  Partials                  74       74           
Components Coverage Δ
access 84.20% <ø> (ø)
catalog 88.59% <ø> (ø)
common 91.80% <ø> (ø)
encryption 72.56% <ø> (ø)
keyring 72.42% <ø> (ø)
src 91.42% <ø> (ø)
smgr 97.41% <ø> (ø)
transam ∅ <ø> (∅)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jeltz jeltz merged commit 7f940c5 into percona:TDE_REL_17_STABLE Jun 6, 2025
16 checks passed
@jeltz jeltz deleted the tde/rm-usless-comments branch June 6, 2025 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants