Clean up KeyringGenerateNewKey()
#399
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of returning NULL when we failed the generate a key we throw an error like all other places where random fails. Additionally we stop hardcoding 32 in the assertion.
Codecov ReportAttention: Patch coverage is
❌ Your project status has failed because the head coverage (85.52%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## TDE_REL_17_STABLE #399 +/- ##
=====================================================
+ Coverage 85.48% 85.52% +0.03%
=====================================================
Files 22 22
Lines 2536 2535 -1
Branches 387 387
=====================================================
Hits 2168 2168
+ Misses 294 293 -1
Partials 74 74
🚀 New features to boost your workflow:
|
dutow
approved these changes
Jun 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of returning NULL when we failed the generate a key we throw an error like all other places where random fails. Additionally we stop hardcoding 32 in the assertion.