Various minor fixes #412
Merged
Various minor fixes #412
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we know that both strings are zero termianted there is no reason to use strncmp().
I forgot to update the name of the argument in the header file.
The comment just says the same thing as the function name.
Codecov ReportAll modified and coverable lines are covered by tests ✅
❌ Your project status has failed because the head coverage (85.50%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## TDE_REL_17_STABLE #412 +/- ##
=====================================================
- Coverage 85.51% 85.50% -0.01%
=====================================================
Files 22 22
Lines 2547 2546 -1
Branches 389 388 -1
=====================================================
- Hits 2178 2177 -1
Misses 293 293
Partials 76 76
🚀 New features to boost your workflow:
|
AndersAstrand
approved these changes
Jun 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are some various code fixes I found in my git stash that did not fit into any other pull request and which were not big enough to justify own PRs.