Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Remove unused system header includes #414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2025

Conversation

jeltz
Copy link
Collaborator

@jeltz jeltz commented Jun 10, 2025

None of these headers were necessary to include, some because they are already included by postgres.h and others because we have removed the functions which we used to use from them.

@jeltz jeltz requested review from dutow and dAdAbird as code owners June 10, 2025 12:50
None of these headers were necessary to include, some because they are
already included by postgres.h and others because we have removed the
functions which we used to use from them.
@jeltz jeltz force-pushed the tde/clean-system-includes branch from 08be5ae to d5744ae Compare June 10, 2025 12:50
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.50%. Comparing base (1749d8c) to head (d5744ae).

❌ Your project status has failed because the head coverage (85.50%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@                  Coverage Diff                  @@
##           TDE_REL_17_STABLE     #414      +/-   ##
=====================================================
- Coverage              85.51%   85.50%   -0.01%     
=====================================================
  Files                     22       22              
  Lines                   2547     2546       -1     
  Branches                 389      388       -1     
=====================================================
- Hits                    2178     2177       -1     
  Misses                   293      293              
  Partials                  76       76              
Components Coverage Δ
access 83.73% <ø> (ø)
catalog 88.88% <ø> (ø)
common 91.80% <ø> (ø)
encryption 72.56% <ø> (ø)
keyring 72.94% <ø> (ø)
src 91.42% <ø> (ø)
smgr 94.85% <ø> (-0.03%) ⬇️
transam ∅ <ø> (∅)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jeltz jeltz merged commit 20891d5 into percona:TDE_REL_17_STABLE Jun 10, 2025
16 checks passed
@jeltz jeltz deleted the tde/clean-system-includes branch June 13, 2025 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants