PG-1663 Make sure indexes on paritioned tables are encrypted #435
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❌ Your project status has failed because the head coverage (84.67%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## release-17.5.2 #435 +/- ##
===============================================
Coverage 84.66% 84.67%
===============================================
Files 21 21
Lines 2589 2590 +1
Branches 402 401 -1
===============================================
+ Hits 2192 2193 +1
Misses 316 316
Partials 81 81
🚀 New features to boost your workflow:
|
ea19845 to
e14d41c
Compare
dutow
reviewed
Jun 16, 2025
| CREATE INDEX ON partition_parent (a); | ||
| ERROR: Recursive CREATE INDEX on a mix of encrypted and unencrypted relations is not supported | ||
| DROP TABLE partition_parent; | ||
| -- Index should also be encrypted for new partitionins |
There was a problem hiding this comment.
What happens if it ends up with mixed encrypted/non encrypted with the additional partition?
There was a problem hiding this comment.
Things will just work since when adding a parition the index's status will be based on the added parition's status, that is not recurisve DDL.
dutow
approved these changes
Jun 17, 2025
|
Just realized, please change the target branch to the release branch |
e14d41c to
97abf7f
Compare
Since we only looked at the parent table and not on the whole tree when setting the status of the encrypted indexes we could easily accidentally create a plain text index on an encrypted table. This patch also makes sure to disallow adding indexes to an inheritance tree where the tables are a mix of encrypted and unecrypted tables.
97abf7f to
6ed8cc7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we only looked at the parent table and not on the whole tree when setting the status of the encrypted indexes we could easily accidentally create a plain text index on an encrypted table.
This patch also makes sure to disallow adding indexes to an inheritance tree where the tables are a mix of encrypted and unecrypted tables.