Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Updated principal-key/features/functions.md based on AA feedback #441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Jun 27, 2025

Conversation

Andriciuc
Copy link
Collaborator

In set-principal-key.md:

  • updated with correct code example using set_server_key_using_global parameter
  • updated note to reflect correct config

In features.md:

  • Removed temporary tables feature to clear confusion, removed logical replication mention, removed WAL encryption as a feature.

In functions.md:

  • Added ON FUNCTION for grant/revoke execution
  • Modified sensitive info bolded paragraph to important note
  • Small modifications to notes display, title cases and text fixes
  • added note to Add or modify Vault providers for keeping the same principal key.
  • Added warning for WAL in pg_tde_create_key_using_global_key_provider

In general:

  • Removed all logical replication mentions except the FAQ and in RC2 release note.

In set-principal-key.md:
* updated with correct code example using set_server_key_using_global parameter
* updated note to reflect correct config

In features.md:
* Removed temporary tables feature to clear confusion, removed logical replication mention, removed WAL encryption as a feature.

In functions.md:
* Added ON FUNCTION for grant/revoke execution
* Modified sensitive info bolded paragraph to important note
* Small modifications to notes display, title cases and text fixes
* added note to Add or modify Vault providers for keeping the same principal key.
* Added warning for WAL in pg_tde_create_key_using_global_key_provider

In general:
* Removed all logical replication mentions except the FAQ and in RC2 release note.
@codecov-commenter
Copy link

codecov-commenter commented Jun 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-17.5.2@aa23578). Learn more about missing BASE report.

Additional details and impacted files
@@                Coverage Diff                @@
##             release-17.5.2     #441   +/-   ##
=================================================
  Coverage                  ?   84.68%           
=================================================
  Files                     ?       21           
  Lines                     ?     2593           
  Branches                  ?      401           
=================================================
  Hits                      ?     2196           
  Misses                    ?      316           
  Partials                  ?       81           
Components Coverage Δ
access 81.11% <0.00%> (?)
catalog 88.22% <0.00%> (?)
common 77.77% <0.00%> (?)
encryption 73.45% <0.00%> (?)
keyring 72.88% <0.00%> (?)
src 91.54% <0.00%> (?)
smgr 94.85% <0.00%> (?)
transam ∅ <0.00%> (?)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Andriciuc Andriciuc changed the title initial update from AA feedback Updated principal-key/features/functions.md based on AA feedback Jun 18, 2025
* fixed keyfile to key file and keyfile proviers to key file providers
* updated remote config options to file paths for specific param warning note.
fixed keyfile to key file for title

Removed warning notes regarding remote config options.
restructured and improved paragraphs create key and creates keys
@Andriciuc Andriciuc removed their assignment Jun 25, 2025
Copy link
Collaborator

@AndersAstrand AndersAstrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Text looks good, please squash before commit.

@nastena1606 nastena1606 temporarily deployed to fixes-for-features-functions-setprincikey - pg-tde-docs PR #441 June 27, 2025 12:07 — with Render Destroyed
@Andriciuc Andriciuc merged commit 8d88d3f into release-17.5.2 Jun 27, 2025
17 checks passed
@Andriciuc Andriciuc deleted the fixes-for-features-functions-setprincikey branch June 27, 2025 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants