Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Updated files in how to and index folders based on AA feedback #444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jun 26, 2025
Merged

Updated files in how to and index folders based on AA feedback #444

merged 12 commits into from
Jun 26, 2025

Conversation

Andriciuc
Copy link
Collaborator

  • Reorganized Uninstall, added warning note and added a new step to ensure user knows he needs to decrypt or drop encrypted tables
  • Updated table access ALTER SYSTEM command do be easier to read
  • updated limitations, removed rewind mention and added WAL note as text, made small changes to RC version. Added note for KMS, improved system tables text.

Multi-tenant-setup.md:

  • updated SELECT parameters
  • Added that KMIP server setup is out of scope.
  • Added a link to KMS configuration chapter in the intro to Key provider config

Andriciuc added 2 commits June 18, 2025 15:18
@Andriciuc
Update multi-tenant-setup.md
e376d34 
updated SELECT parameters
Added that KMIP server setup is out of scope.
Added a link to KMS configuration chapter in the intro to Key provider config
@Andriciuc
updated uninstall/table-access/
7c0b59b 
* Reorganized Uninstall, added warning note and added a new step to ensure user knows he needs to decrypt or drop encrypted tables
* Updated table access ALTER SYSTEM command do be easier to read
*  updated limitations, removed rewind mention and added WAL note as text, made small changes to RC version. Added note for KMS, improved system tables text.
@Andriciuc Andriciuc requested a review from AndersAstrand June 19, 2025 10:40
@Andriciuc Andriciuc self-assigned this Jun 19, 2025
@Andriciuc Andriciuc requested a review from nastena1606 as a code owner June 19, 2025 10:40
@Andriciuc Andriciuc added the documentation Improvements or additions to documentation label Jun 19, 2025
@Andriciuc Andriciuc changed the title Improvements to how to and index folders Improvements to how to and index folders based on AA feedback Jun 19, 2025
@Andriciuc Andriciuc changed the title Improvements to how to and index folders based on AA feedback Doc improvements to how to and index folders based on AA feedback Jun 19, 2025
@Andriciuc Andriciuc changed the title Doc improvements to how to and index folders based on AA feedback Updated files in how to and index folders based on AA feedback Jun 19, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jun 19, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests βœ…

Please upload report for BASE (release-17.5.2@5191b68). Learn more about missing BASE report.

Additional details and impacted files 
@@                Coverage Diff                @@
##             release-17.5.2     #444   +/-   ##
=================================================
  Coverage                  ?   84.68%           
=================================================
  Files                     ?       21           
  Lines                     ?     2593           
  Branches                  ?      401           
=================================================
  Hits                      ?     2196           
  Misses                    ?      316           
  Partials                  ?       81
Components Coverage Ξ”
access 81.11% <0.00%> (?)
catalog 88.22% <0.00%> (?)
common 77.77% <0.00%> (?)
encryption 73.45% <0.00%> (?)
keyring 72.88% <0.00%> (?)
src 91.54% <0.00%> (?)
smgr 94.85% <0.00%> (?)
transam βˆ… <0.00%> (?)
πŸš€ New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Andriciuc Andriciuc removed their assignment Jun 25, 2025
AndersAstrand
AndersAstrand reviewed Jun 26, 2025
View reviewed changes
@Andriciuc
minor text fix for step 1
12a825e 
minor text fix.
AndersAstrand
AndersAstrand reviewed Jun 26, 2025
View reviewed changes
@Andriciuc
small param update
c454858 
small param update
@nastena1606 nastena1606 temporarily deployed to improvements-to-how-to-and-index-folders - pg-tde-docs PR #444 June 26, 2025 10:17 — with Render Destroyed
AndersAstrand
AndersAstrand reviewed Jun 26, 2025
View reviewed changes
@AndersAstrand
Copy link
Collaborator

The text looks good now, I had a question about a possibly missing newline. Please do not mention that it was based on my comments in the commit message, describe what the commit will do if applied instead :).

@nastena1606 nastena1606 temporarily deployed to improvements-to-how-to-and-index-folders - pg-tde-docs PR #444 June 26, 2025 11:16 — with Render Destroyed
AndersAstrand
AndersAstrand approved these changes Jun 26, 2025
View reviewed changes
Copy link
Collaborator

@AndersAstrand AndersAstrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Text looks good. Please squash before committing

@Andriciuc Andriciuc merged commit 26eecc7 into release-17.5.2 Jun 26, 2025
16 of 17 checks passed
@Andriciuc Andriciuc deleted the improvements-to-how-to-and-index-folders branch June 26, 2025 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndersAstrand AndersAstrand AndersAstrand approved these changes

@nastena1606 nastena1606 Awaiting requested review from nastena1606 nastena1606 is a code owner

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Andriciuc @codecov-commenter @AndersAstrand @nastena1606