Remove pluralization of enum name #452
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❌ Your project status has failed because the head coverage (84.66%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## TDE_REL_17_STABLE #452 +/- ##
==================================================
Coverage 84.65% 84.66%
==================================================
Files 21 21
Lines 2588 2589 +1
Branches 401 402 +1
==================================================
+ Hits 2191 2192 +1
Misses 316 316
Partials 81 81
🚀 New features to boost your workflow:
|
jeltz
approved these changes
Jun 25, 2025
Do you have a suggestion on how to word this? Is there anything documented about it or is it just what postgresql mostly does? |
artemgavrilov
approved these changes
Jun 25, 2025
Having this enum named as a plural made little sense as any value of this type is just a single code and not multiple. The postgres code does not have pluralized enum names, so we shouldn't either.
886b69c to
2a2bbac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having this enum named as a plural made little sense as any value of this type is just a single code and not multiple.