Thanks to visit codestin.com
Credit goes to github.com

Skip to content

PG-1257 Add key deletion funcs to documentation #456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 26, 2025
Merged

PG-1257 Add key deletion funcs to documentation #456

merged 1 commit into from
Jun 26, 2025
+18 −2

Conversation

artemgavrilov
Copy link
Collaborator

Missing documentation for key deletion functions. Fix couple uncertainties on architecture docs page.

@artemgavrilov artemgavrilov marked this pull request as ready for review June 26, 2025 14:44
Andriciuc
Andriciuc approved these changes Jun 26, 2025
View reviewed changes
Copy link
Collaborator

@Andriciuc Andriciuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, please use the release-17.5.2 base branch to commit these updates

@artemgavrilov artemgavrilov changed the base branch from TDE_REL_17_STABLE to release-17.5.2 June 26, 2025 14:53
@artemgavrilov
PG-1257 Add key deletion funcs to documentation
849ffce 
Add principal key deletion functions to documentation. Fix couple
uncertainties on architecture docs page.
@nastena1606 nastena1606 temporarily deployed to PG-1257-docs-update - pg-tde-docs PR #456 June 26, 2025 14:59 — with Render Destroyed
@nastena1606 nastena1606 temporarily deployed to PG-1257-docs-update - INTERNAL-pg_tde docs PR #456 June 26, 2025 14:59 — with Render Destroyed
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-17.5.2@c94be04). Learn more about missing BASE report.

Additional details and impacted files 
@@                Coverage Diff                @@
##             release-17.5.2     #456   +/-   ##
=================================================
  Coverage                  ?   84.69%           
=================================================
  Files                     ?       21           
  Lines                     ?     2594           
  Branches                  ?      402           
=================================================
  Hits                      ?     2197           
  Misses                    ?      316           
  Partials                  ?       81
Components Coverage Δ
access 81.11% <0.00%> (?)
catalog 88.22% <0.00%> (?)
common 77.77% <0.00%> (?)
encryption 73.45% <0.00%> (?)
keyring 72.88% <0.00%> (?)
src 91.54% <0.00%> (?)
smgr 94.88% <0.00%> (?)
transam ∅ <0.00%> (?)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@artemgavrilov artemgavrilov merged commit 5a2c081 into release-17.5.2 Jun 26, 2025
23 of 29 checks passed
@artemgavrilov artemgavrilov deleted the PG-1257-docs-update branch June 26, 2025 15:43
@shahidullah79
Copy link
Collaborator

pg_tde_delete_key and pg_tde_delete_default_key don't delete the keys. It only unset the keys for current database but the keys are still there and user can set it any time without recreating the key. @dutow your thoughts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Andriciuc Andriciuc Andriciuc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@artemgavrilov @codecov-commenter @shahidullah79 @Andriciuc @nastena1606