Thanks to visit codestin.com
Credit goes to github.com

Skip to content

SDK Version Check #1967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Aug 28, 2025
Merged

SDK Version Check #1967

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
f2ded0c
SDK Version Check
ayushatstack Aug 18, 2025
52835c6
changed placement
ayushatstack Aug 19, 2025
886bbc7
using github api again
ayushatstack Aug 20, 2025
3caae8c
sdk parsing
ayushatstack Aug 21, 2025
00fe685
lint fix
ayushatstack Aug 21, 2025
e34920c
lint fix 2
ayushatstack Aug 21, 2025
09de611
Update packages/core/src/utils.js
ayushatstack Aug 21, 2025
20a5981
added tests
ayushatstack Aug 22, 2025
44b4b02
Merge branch 'master' into PPLT_4314
ayushatstack Aug 22, 2025
a9e3a81
trigger test
ayushatstack Aug 22, 2025
17eed8d
changed import
ayushatstack Aug 22, 2025
a3e86f4
retrigger test
ayushatstack Aug 22, 2025
7e5558f
request to top
ayushatstack Aug 22, 2025
57de13e
changes
ayushatstack Aug 25, 2025
3fdb387
more tests to imporve coverage
ayushatstack Aug 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
changes
  • Loading branch information
@ayushatstack
ayushatstack committed Aug 25, 2025
commit 57de13e15e6c0a28265bad7fd160b7ce1eefa115
3 changes: 1 addition & 2 deletions packages/core/src/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -630,14 +630,13 @@ export async function checkSDKVersion(clientInfo) {
}

// Fetch latest version from GitHub releases
const githubData = await request(`https://api.github.com/repos/percy/${repoName}/releases`, {
const githubData = await request(`https://api.github.com/repos/percy/${repoName}/releases?page=1`, {
headers: { 'User-Agent': '@percy/cli' },
retries: 0
});

const latestRelease = githubData.find(r => !r.prerelease);
if (!latestRelease) {
log.debug('No stable release found');
return;
}

Expand Down
12 changes: 0 additions & 12 deletions packages/core/test/utils.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,22 +262,10 @@ describe('utils', () => {
expect(logger.stderr).toContain('[percy:core:sdk-version] [SDK Update Available] @percy/selenium-webdriver: 2.2.0 -> 2.3.0');
});

it('handles no stable releases found', async () => {
ghAPI.and.returnValue([200, [{ tag_name: 'v3.0.0-beta.1', prerelease: true }]]);
await checkSDKVersion('@percy/selenium-webdriver/2.2.0');
expect(logger.stderr).toContain('[percy:core:sdk-version] No stable release found');
});

it('handles request errors gracefully', async () => {
ghAPI.and.returnValue([500, 'Internal Server Error']);
await checkSDKVersion('@percy/selenium-webdriver/2.2.0');
expect(logger.stderr).toContain('[percy:core:sdk-version] Could not check SDK version');
});

it('handles empty releases array', async () => {
ghAPI.and.returnValue([200, []]);
await checkSDKVersion('@percy/selenium-webdriver/2.2.0');
expect(logger.stderr).toContain('[percy:core:sdk-version] No stable release found');
});
});
});
Loading