Thanks to visit codestin.com
Credit goes to github.com

Skip to content

internal, blobserver: add robutio package and use in osfs #1667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MichaHoffmann
Copy link
Member

Windows renames can be flaky, which can lead to problems when we tried to add a receive hook for the indexer. To address this we copy the robustio package from
https://github.com/golang/go/tree/master/src/cmd/go/internal/robustio.

@MichaHoffmann MichaHoffmann force-pushed the mhoffm-robust-io-for-files-based-blobservers branch 2 times, most recently from 6221753 to 4acb954 Compare January 1, 2024 18:52
Windows renames can be flaky, which can lead to problems when we tried
to add a receive hook for the indexer. To address this we copy the
robustio package from
https://github.com/golang/go/tree/master/src/cmd/go/internal/robustio.

Signed-off-by: Michael Hoffmann <[email protected]>
@MichaHoffmann MichaHoffmann force-pushed the mhoffm-robust-io-for-files-based-blobservers branch from 4acb954 to 025c455 Compare January 1, 2024 19:01
@@ -0,0 +1,11 @@
package robustio
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a package doc here, per https://go.dev/wiki/CodeReviewComments#package-comments

// Package robustio ....
package robustio

@bradfitz
Copy link
Contributor

add robutio package

Typo in PR title

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants