add webp and svg support for images #1695
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd also be happy to try to fix the underlying issue with webp if someone can point me in the right direction, assuming thats the actual issue and i'm not doing something wrong with the uploader |
|
added |
|
Updated to add support for displaying svg images |
bradfitz
reviewed
May 27, 2025
"have this attribute missing" What is "this"? Can you squash these commits in this PR down to one commit and write a bit more of a commit message with backstory instead of just "handle undefined image" ? |
* adds webp format support (one line change) * adds svg support (bulk of the changes) * Fixes frontend bug The frontend bug is a one-line change, and happens in this scenario: * the mime magic detects the image as "image/whatever" * Go image decoder does not support the image format This causes the indexer to enter a semi-broken state, where its identified the image as an image, but has not assigned it dimensions. If this file is then assigned as a `camliContentImage`, it will break, due to `ccim.image` being undefined.
|
@bradfitz Yeah, squashed / updated commit message, also updated PR description about what "undefined image" is referring to. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does three things:
The frontend bug is a one-line change, and happens in this scenario:
This causes the indexer to enter a semi-broken state, where its identified the image as an image, but has not assigned it dimensions. If this file is then assigned as a
camliContentImage, it will break, due toccim.imagebeing undefined.