Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@ehuelsmann
Copy link
Member

Description

Deprecate/ remove the empty ::Mailer action; as per the note in the "2.0" project, it's empty and filling it would introduce undesirable additional dependencies.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project, please see the contribution guidelines.
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes

Not applicable:

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

You might think, that this is one crazy checklist, but it is just as much written for the maintainer of the involved software :-)

@ehuelsmann ehuelsmann added this to the 2.0 milestone Jul 14, 2021
@ehuelsmann ehuelsmann requested a review from jonasbn July 14, 2021 19:14
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.05%) to 82.271% when pulling d8dd311 on ehuelsmann:rm-mailer-action into 6e9a399 on jonasbn:master.

Copy link
Collaborator

@jonasbn jonasbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, mailer will go

@jonasbn jonasbn merged commit 34377af into perl-workflow:master Jul 29, 2021
@ehuelsmann ehuelsmann deleted the rm-mailer-action branch August 3, 2021 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants