Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Without preceeding eval{}, don't check $EVAL_ERROR #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jonasbn merged 1 commit into from
Jul 30, 2021
Merged

Without preceeding eval{}, don't check $EVAL_ERROR #146

jonasbn merged 1 commit into from
Jul 30, 2021

Conversation

@ehuelsmann
Copy link
Member

@ehuelsmann ehuelsmann commented Jul 30, 2021

Description

Since $EVAL_ERROR isn't explicitly bound to be undef, its
value could be a left-over value from anywhere else, which could
trigger an exception being thrown without there being good reason.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project, please see the contribution guidelines.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@ehuelsmann
Without preceeding eval{}, don't check $EVAL_ERROR
f1e49dd 
Since $EVAL_ERROR isn't explicitly bound to be `undef`, its
value could be a left-over value from anywhere else, which *could*
trigger an exception being thrown without there being good reason.
@coveralls
Copy link

coveralls commented Jul 30, 2021

Coverage Status

Coverage increased (+0.04%) to 85.105% when pulling f1e49dd on ehuelsmann:rm-dead-code into 6970b65 on jonasbn:master.

jonasbn
jonasbn approved these changes Jul 30, 2021
View reviewed changes
Copy link
Collaborator

@jonasbn jonasbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that looks pretty useless

@jonasbn jonasbn merged commit 9fd86a8 into perl-workflow:master Jul 30, 2021
@jonasbn jonasbn added this to the 2.0 milestone Jul 31, 2021
@jonasbn jonasbn added the bug label Jul 31, 2021
@ehuelsmann ehuelsmann deleted the rm-dead-code branch August 3, 2021 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jonasbn jonasbn jonasbn approved these changes

Assignees

No one assigned

Labels

bug

Projects

No open projects
2.0
Status: Done

Milestone

2.0

Development

Successfully merging this pull request may close these issues.

3 participants

@ehuelsmann @coveralls @jonasbn