Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@ehuelsmann
Copy link
Member

Description

However, if we were to use Log::ger or Log::Any, none of this would be an issue.

Type of change

@coveralls
Copy link

Coverage Status

Coverage remained the same at 86.174% when pulling d8e1fea on ehuelsmann:reduce-l4p-init-warnings into 94d63c5 on jonasbn:master.

Copy link
Collaborator

@jonasbn jonasbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I am pondering changing the test-suite to a Test::Class based implementation, so we can simplify the test suite and make the initial set up uniform

@jonasbn jonasbn merged commit a756000 into perl-workflow:master Jul 31, 2021
@jonasbn jonasbn added the maintenance Maintenance of tools and configuration label Jul 31, 2021
@jonasbn jonasbn added this to the 2.0 milestone Jul 31, 2021
@ehuelsmann
Copy link
Member Author

@jonasbn about the Test::Class idea to reduce setup: I think that's what TestUtil.pm in t/ is supposed to do (but apparently failing at).

There's one failure mode (the one which is currently still generating the output) which we cannot solve by adding Test::Class, TestUtil or inclusion directly in the test scripts: the scripts generated automatically by Dist::Zilla to validate POD coverage. These scripts load the modules to inspect the resulting packages for "public" symbols bound to coderefs (i.e. available functions). Loading the code without initializing Log::Log4perl causes exactly this warning. My advocacy for using Log::Any is because it separates the concerns of log producers and log consumers. If there's no registered log consumer, there's no warning. There's just nothing. And from the perspective of anything in lib/ we're only log producers.

@ehuelsmann ehuelsmann deleted the reduce-l4p-init-warnings branch August 3, 2021 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Maintenance of tools and configuration

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants