Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Eliminate warnings from configuration errors being printed on STDOUT #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jonasbn merged 1 commit into from
Jul 31, 2021
Merged

Eliminate warnings from configuration errors being printed on STDOUT #155

jonasbn merged 1 commit into from
Jul 31, 2021

Conversation

@ehuelsmann
Copy link
Member

@ehuelsmann ehuelsmann commented Jul 31, 2021

Description

Instead of printing the warnings on STDOUT (which may blead through on a terminal), send the warnings to the logger.

Type of change

  • Maintenance

Checklist:

  • My code follows the style guidelines of this project, please see the contribution guidelines.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@coveralls
Copy link

coveralls commented Jul 31, 2021

Coverage Status

Coverage increased (+0.03%) to 88.522% when pulling 649bca6 on ehuelsmann:no-config-warnings-stdout into 5315810 on jonasbn:master.

@ehuelsmann ehuelsmann requested a review from jonasbn July 31, 2021 10:35
@jonasbn jonasbn added this to the 2.0 milestone Jul 31, 2021
@jonasbn jonasbn added the maintenance Maintenance of tools and configuration label Jul 31, 2021
jonasbn
jonasbn approved these changes Jul 31, 2021
View reviewed changes
Copy link
Collaborator

@jonasbn jonasbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@jonasbn jonasbn merged commit 4f6e4e3 into perl-workflow:master Jul 31, 2021
@ehuelsmann ehuelsmann deleted the no-config-warnings-stdout branch August 3, 2021 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jonasbn jonasbn jonasbn approved these changes

Assignees

No one assigned

Labels

maintenance Maintenance of tools and configuration

Projects

No open projects
2.0
Status: Done

Milestone

2.0

Development

Successfully merging this pull request may close these issues.

3 participants

@ehuelsmann @coveralls @jonasbn