Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@jonasbn
Copy link
Collaborator

@jonasbn jonasbn commented Jul 31, 2021

Description

Please include a summary of the proposed improvement or addressed issue.

Fixes/addresses (If applicable) # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project, please see the contribution guidelines.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

You might think, that this is one crazy checklist, but it is just as much written for the maintainer of the involved software :-)

@jonasbn jonasbn requested a review from ehuelsmann July 31, 2021 10:27
@coveralls
Copy link

Coverage Status

Coverage remained the same at 88.488% when pulling 29dc945 on change_log_update into 5315810 on master.

Copy link
Member

@ehuelsmann ehuelsmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, theres' some additional background in the PR. Good to point there.

@ehuelsmann ehuelsmann merged commit 938bde3 into master Jul 31, 2021
@delete-merged-branch delete-merged-branch bot deleted the change_log_update branch July 31, 2021 10:38
@jonasbn jonasbn added the maintenance Maintenance of tools and configuration label Jul 31, 2021
@jonasbn jonasbn added this to the 2.0 milestone Jul 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Maintenance of tools and configuration

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants