Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@ehuelsmann
Copy link
Member

Description

Please include a summary of the proposed improvement or addressed issue.

Fixes/addresses (If applicable) # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project, please see the contribution guidelines.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

You might think, that this is one crazy checklist, but it is just as much written for the maintainer of the involved software :-)

("The example ticketing application" =>
sub {
requires 'DBD::SQLite';
requires 'DBI';
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jonasbn by dropping the web component and switching to the File persister, we can drop the two above and all of the ones in the section below.

@ehuelsmann ehuelsmann requested a review from jonasbn August 1, 2021 11:10
@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.297% when pulling 5d4c1c2 on ehuelsmann:cpanfile-update into f11a15b on jonasbn:master.

Copy link
Collaborator

@jonasbn jonasbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@jonasbn jonasbn merged commit 91a43f8 into perl-workflow:master Aug 1, 2021
@jonasbn jonasbn added the maintenance Maintenance of tools and configuration label Aug 1, 2021
@jonasbn jonasbn added this to the 2.0 milestone Aug 1, 2021
@ehuelsmann ehuelsmann deleted the cpanfile-update branch August 3, 2021 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Maintenance of tools and configuration

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants