Stop listing observer related methods as internal #165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most definitely, `add_observer` isn't internal: this is a method anyone could be willing to use programmatically in addition to the declarative way of subscribing observers through configuration.
Member
Author
|
This PR is a matter of expectations about the use of the API: do we expect these methods to be available to users of the library to add their own observers irrespective of what's been declared in the XML? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add_observerisn't internal: this is a method anyonecould be willing to use programmatically in addition to the declarative
way of subscribing observers through configuration?
While writing this PR, I noted that Workflow doesn't support half the functionality supported (for its observers) by e.g. Role::EventEmitter.
Type of change
I suppose this is a documentation fix (to be confirmed by @jonasbn)
Checklist: