Allow user-selectable history class #168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
I'm pondering the 'breakingchange' tag. I'm not actually sure this one breaks anything: there was no need to adapt the test suite to implement this change... |
Closes perl-workflow#106. Moves the responsibility of instantiating history classes from the factory and the persister into the Workflow class.
d66f36a to
8e2cea3
Compare
Member
Author
|
Step 1: conflicts resolved. |
Note that the actions were inserting history items of type 'Workflow::History' which is the supertype of the configured history item. Change the history addition to simply provide the construction parameters of the history object instead of providing the history object itself.
- Merge two constant strings which would be concatenated later - Indentation in a code example for better readability
Since the history class can be changed on the workflow, it's the responsibility of Workflow to instantiate its history items. In our examples, promote that pattern (instead of the older pattern where the history class would be hard-coded).
Member
Author
|
Step 2: Add tests and documentation tweaks. |
Member
Author
|
@jonasbn this PR is now ready for final review and merging. Please note that although I changed the code in the test suite to stop adding |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #106. Moves the responsibility of instantiating history classes from the factory
and the persister into the Workflow class.
Type of change
Checklist: