Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Replace use base with use parent #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jonasbn merged 2 commits into from
Aug 4, 2021
Merged

Replace use base with use parent #169

jonasbn merged 2 commits into from
Aug 4, 2021

Conversation

@ehuelsmann
Copy link
Member

@ehuelsmann ehuelsmann commented Aug 4, 2021

Description

Because use parent is the Perl 5.10+ way to do this and because
parent is dual life, so older perls benefit as well.

Type of change

  • Maintenance

Checklist:

  • My code follows the style guidelines of this project, please see the contribution guidelines.
  • I have performed a self-review of my own code
  • [n/a] I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • [n/a] I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@ehuelsmann
Replace use base with use parent
f758410 
Because `use parent` is the Perl 5.10+ way to do this *and* because
`parent` is dual life, so older perls benefit as well.
@ehuelsmann
Change documentation examples to show use parent
8ed3e97
@ehuelsmann ehuelsmann requested a review from jonasbn August 4, 2021 17:51
@ehuelsmann ehuelsmann added the maintenance Maintenance of tools and configuration label Aug 4, 2021
@coveralls
Copy link

coveralls commented Aug 4, 2021

Coverage Status

Coverage remained the same at 92.201% when pulling 8ed3e97 on ehuelsmann:replace-base-with-parent into 5fa35d9 on jonasbn:master.

jonasbn
jonasbn approved these changes Aug 4, 2021
View reviewed changes
Copy link
Collaborator

@jonasbn jonasbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@jonasbn jonasbn merged commit 2c01772 into perl-workflow:master Aug 4, 2021
@jonasbn jonasbn added this to the 2.0 milestone Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jonasbn jonasbn jonasbn approved these changes

Assignees

No one assigned

Labels

maintenance Maintenance of tools and configuration

Projects

No open projects
2.0
Status: Done

Milestone

2.0

Development

Successfully merging this pull request may close these issues.

3 participants

@ehuelsmann @coveralls @jonasbn