Don't log from use Workflow::Factory qw( FACTORY );
#170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Logging during import breaks the generally accepted convention of using modules and *then* doing all the work, like initialization. Logging during import() is simply 'too early'.
jonasbn
approved these changes
Oct 12, 2021
ehuelsmann
added a commit
that referenced
this pull request
Oct 12, 2021
Logging during import breaks the generally accepted convention of using modules and *then* doing all the work, like initialization. Logging during import() is simply 'too early'.
Collaborator
|
Moved to milestone 1.57 from 2.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Logging during import breaks the generally accepted convention
of using modules and then doing all the work, like initialization.
Logging during import() is simply 'too early' and causes truckloads of "Log4perl not initialized" warnings in LedgerSMB.
Type of change
Please delete options that are not relevant.
Checklist:
You might think, that this is one crazy checklist, but it is just as much written for the maintainer of the involved software :-)