Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@ehuelsmann
Copy link
Member

Description

Note that this commit changes 'import()' in the sense that it no
longer returns the instance. However, there's no documentation that
it should.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project, please see the contribution guidelines.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Note that this commit changes 'import()' in the sense that it no
longer returns the instance. However, there's no documentation that
it should.
Copy link
Collaborator

@jonasbn jonasbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@jonasbn jonasbn added this to the 2.0 milestone Nov 13, 2021
@jonasbn
Copy link
Collaborator

jonasbn commented Nov 13, 2021

Oh, we seem to have a minor conflict

@ehuelsmann
Copy link
Member Author

Sorry about that. Conflict has been resolved now.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 92.169% when pulling c7926e1 on ehuelsmann:1.x-delay-instantiation into 096b94c on jonasbn:master.

Copy link
Collaborator

@jonasbn jonasbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@jonasbn jonasbn merged commit 3168b86 into perl-workflow:master Nov 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants