Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Dedupe Workflow::Context::init() #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jonasbn merged 1 commit into from
Jan 11, 2022
Merged

Dedupe Workflow::Context::init() #179

jonasbn merged 1 commit into from
Jan 11, 2022

Conversation

@ehuelsmann
Copy link
Member

@ehuelsmann ehuelsmann commented Jan 9, 2022

Description

Deduplicate function duplicated by automatic merge.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes

@coveralls
Copy link

coveralls commented Jan 9, 2022

Coverage Status

Coverage increased (+0.2%) to 92.377% when pulling e2ae69a on ehuelsmann:dedupe-ctx-init into 2f8017c on jonasbn:master.

@ehuelsmann ehuelsmann requested a review from jonasbn January 11, 2022 17:34
jonasbn
jonasbn approved these changes Jan 11, 2022
View reviewed changes
Copy link
Collaborator

@jonasbn jonasbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonasbn jonasbn added this to the 1.58 milestone Jan 11, 2022
@jonasbn jonasbn merged commit 8ae8d0e into perl-workflow:master Jan 11, 2022
@jonasbn jonasbn added the bug label Jan 11, 2022
@ehuelsmann ehuelsmann deleted the dedupe-ctx-init branch January 17, 2022 20:31
@jonasbn
Copy link
Collaborator

jonasbn commented Jan 27, 2022

@ehuelsmann can you restore this branch?

@ehuelsmann ehuelsmann restored the dedupe-ctx-init branch January 27, 2022 20:33
@ehuelsmann ehuelsmann deleted the dedupe-ctx-init branch January 27, 2022 21:54
@ehuelsmann
Copy link
Member Author

ehuelsmann commented Jan 28, 2022

@jonasbn This PR/commit does not need backporting to 1.x as there is no duplicate init() function there (at the moment).

@jonasbn
Copy link
Collaborator

jonasbn commented Jan 28, 2022

Great, marking this as milestone 2.0

@jonasbn jonasbn modified the milestones: 1.58, 2.0 Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jonasbn jonasbn jonasbn approved these changes

Assignees

No one assigned

Labels

bug

Projects

No open projects
2.0
Status: Done

Milestone

2.0

Development

Successfully merging this pull request may close these issues.

3 participants

@ehuelsmann @coveralls @jonasbn