Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Feature/independent observers #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jonasbn merged 2 commits into from
Oct 1, 2022
Merged

Feature/independent observers #205

jonasbn merged 2 commits into from
Oct 1, 2022

Conversation

@ehuelsmann
Copy link
Member

@ehuelsmann ehuelsmann commented Sep 30, 2022

Description

This PR adds the ability to specify observers without changing the workflow definition. This enables customization of software without customizing the workflow file when the workflow is acceptable, but additional actions need to be triggered on state changes.)

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project, please see the contribution guidelines.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

You might think, that this is one crazy checklist, but it is just as much written for the maintainer of the involved software :-)

@ehuelsmann
Factor out commonality in config file loader
91a897b
@ehuelsmann
Add support for independently specified observers
ed40226 
This allows the workflow definition to remain unchanged when
customizing a code base using observers to trigger follow-up
actions.
@ehuelsmann ehuelsmann requested a review from jonasbn September 30, 2022 07:03
@coveralls
Copy link

coveralls commented Sep 30, 2022

Coverage Status

Coverage increased (+0.1%) to 92.329% when pulling ed40226 on feature/independent-observers into 57334b6 on master.

jonasbn
jonasbn approved these changes Oct 1, 2022
View reviewed changes
Copy link
Collaborator

@jonasbn jonasbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ehuelsmann

This looks very good, a very nice contribution - thanks

@jonasbn jonasbn merged commit fb75279 into master Oct 1, 2022
@delete-merged-branch delete-merged-branch bot deleted the feature/independent-observers branch October 1, 2022 07:45
@jonasbn jonasbn added this to the 2.0 milestone Oct 1, 2022
@jonasbn jonasbn added the enhancement Feature/improvement label Oct 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jonasbn jonasbn jonasbn approved these changes

Assignees

No one assigned

Labels

enhancement Feature/improvement

Projects

No open projects
2.0
Status: Done

Milestone

2.0

Development

Successfully merging this pull request may close these issues.

4 participants

@ehuelsmann @coveralls @jonasbn